623228 - WebGL context destruction hangs on Droid

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

We hang on the call to glDeleteFramebuffers

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Seems to be because we're calling glDeleteFramebuffers on framebuffers we never created.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

exciting -- where do we do this call?  mOffscreenFBO (if that's the FBO we're talking about) is initialized to 0, and deleting it is supposed to be silently ignored.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

calling glDeleteFramebuffers with 0 as the number seems to cause hangs on the Droid. I think the best thing to do is just check before we call glDeleteFramebuffers.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Ok, but please find a way to report this bug to Motorola or PowerVR -- this basically means we'll have to either protect every other delete function as well or we'll have to disable things like WebGL.  disabling WebGL on the Droid is no big loss though

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Share the gl wrappers in release/debug versions

This makes it easier to add code for ignoring certain calls etc.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 501448 [details] [diff] [review]
Share the gl wrappers in release/debug versions

Looks fine, but:

>+#define TRACKING_CONTEXT(a) TrackingContext()->a
>+#else
>+#define TRACKING_CONTEXT(a)

make this "do { } while (0)", otherwise we have dangling ; 's in the code.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Attachment: Avoid glDeleteFramebuffers(1, &0);

This only handles the case where n == 1, I'm not sure if that's ok or not.

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 501503 [details] [diff] [review]
Avoid glDeleteFramebuffers(1, &0);

it's probably ok for this particular case since we know how it's called

Comment 10

[Jeff Muizelaar [:jrmuizel]]

http://hg.mozilla.org/mozilla-central/rev/78e5ed32f8f5
http://hg.mozilla.org/mozilla-central/rev/57103cddaf37

Comment 11

[Oleg Romashin (:romaxa)]

Hmm we had similar problem on Maemo SGX... but that was fixed in maemo6 SDK.
https://bugzilla.mozilla.org/show_bug.cgi?id=598970#c0