623241 - Add-on notifications should be moved from the top of the add-on item to the top right of the list view items.

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: error message displayed on the top right of each add-on in list view

This placement provides a number of benefits visually:

• It does not require that add-on entries change their vertical height, which keeps list view consistently sized in all states
• It makes it easier to visually scan the right of items to see notifications
• From the old design, it more easily distinguishes which add-on has the notification

If more information about a particular notification is needed (eg why an add-on is blocked) or the message is truncated, full information will be give in the add-on's detailed view.

Comment 1

[Luke Iliffe (Harlequin99)]

In your mockup the proposed design doesn't include the 'restart now?' hyperlink after installation or a change in enabled state. Is this intended or just an oversight in the mockup?

Comment 2

[Jennifer Morrow [:Boriss] (UX)]

(In reply to comment #1)
> In your mockup the proposed design doesn't include the 'restart now?' hyperlink
> after installation or a change in enabled state. Is this intended or just an
> oversight in the mockup?

This is intended.  It was removed to simplify the UI and present only the buttons that are absolutely necessary (not covered elsewhere in the UI).

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #2)
> (In reply to comment #1)
> > In your mockup the proposed design doesn't include the 'restart now?' hyperlink
> > after installation or a change in enabled state. Is this intended or just an
> > oversight in the mockup?
> 
> This is intended.  It was removed to simplify the UI and present only the
> buttons that are absolutely necessary (not covered elsewhere in the UI).

Where is the option to restart meant to appear then?

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Feels too risky this late in the game, but if we end up with lots of time on our hands, would consider an approval.

Comment 5

[Geoff Lankow (:darktrojan)]

Taking this, although I may lack time to get it to completion in the next week or so. It's also going to need strings approval.

The mockup lacks the diagonal stripes. Are they to be removed?

Comment 6

[Dave Townsend [:mossop]]

As a non-blocker this isn't something we'll be considering breaking string freeze for, I wouldn't expect it is likely a patch for this would get approval to land for Firefox 4 at this stage.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: WIP patch

Comment 8

[Geoff Lankow (:darktrojan)]

Should've pointed out that my patch won't apply cleanly without first applying my patch on bug 623207.

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 506001 [details] [diff] [review]
WIP patch

As with comment 4 and comment 6, I really don't think this is something that should be considered for 4.0, so late in the game. I like the general idea, but there are too many issues with the details. My main concern is layout issues - specifically, restricting the space the addon name has, which is already cropped for some users (see the fun of bug 567652, and the hack to make that work). The shorter strings help a little with that, but not enough, IMO (some locales and screen sizes will be worse than others). As Dave said, it's too late for string changes anyway. (As a side-note, the new wording isn't using full sentences and sounds inconsistent with the rest of Firefox). There's also the issue of cropping/wrapping the notification text - not sure how that's going to work out, given the addon name needs to crop too. And finally, we need to keep the restart buttons in these notifications - since there's no restart button anywhere else (see bug 553460 - which AFAIK was going to be a WONTFIX). And also the undo button needs to stay, at least until it can be added elsewhere (like the mockup shows) - which is additional risk (we get the undo buton for free right now - moving it will require code to figure out when to show it, and what label to give it).

Comment 10

[Jennifer Morrow [:Boriss] (UX)]

(In reply to comment #9)
> Comment on attachment 506001 [details] [diff] [review]
> WIP patch
> 
> As with comment 4 and comment 6, I really don't think this is something that
> should be considered for 4.0, so late in the game. I like the general idea, but
> there are too many issues with the details. My main concern is layout issues -
> specifically, restricting the space the addon name has, which is already
> cropped for some users (see the fun of bug 567652, and the hack to make that
> work). The shorter strings help a little with that, but not enough, IMO (some
> locales and screen sizes will be worse than others). As Dave said, it's too
> late for string changes anyway. (As a side-note, the new wording isn't using
> full sentences and sounds inconsistent with the rest of Firefox). There's also
> the issue of cropping/wrapping the notification text - not sure how that's
> going to work out, given the addon name needs to crop too. And finally, we need
> to keep the restart buttons in these notifications - since there's no restart
> button anywhere else (see bug 553460 - which AFAIK was going to be a WONTFIX).
> And also the undo button needs to stay, at least until it can be added
> elsewhere (like the mockup shows) - which is additional risk (we get the undo
> buton for free right now - moving it will require code to figure out when to
> show it, and what label to give it).

Agreed.  Unfortunately, this won't make the 4.0 boat.  Lacking a better tag, I'm  marking this for future.

Comment 11

[Siddhartha Dugar [:sdrocking]]

Would love to see this land

Comment 12

[Geoff Lankow (:darktrojan)]

Boriss, Mossop, Unfocused: ping?

I'd like to hide the text and restart now/undo buttons, leaving just the icon, at lower widths like we do with the global warning. (I'm also keen to hide the options/disable/remove buttons at lower widths but that's probably another discussion altogether.)

Comment 13

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #12)
> I'd like to hide the text and restart now/undo buttons, leaving just the icon,
> at lower widths like we do with the global warning. (I'm also keen to hide the
> options/disable/remove buttons at lower widths but that's probably another
> discussion altogether.)

Can you update your patch with your proposed changes? And any additional changes to solve the issues I mentioned in comment 9. Then Boriss can play around with it at different window sizes.

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: WIP patch

I think on windows >900px wide this all looks fine, but there isn't enough room for the text and the links/buttons on narrower windows.

Comment 15

[Geoff Lankow (:darktrojan)]

We could put the restart/undo items in a menupopup and display a dropmarker. Just a thought.

Comment 16

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #15)
> We could put the restart/undo items in a menupopup and display a dropmarker.
> Just a thought.

Don't think that's something we want to hide. A menu-button may work, but we don't use that anywhere else, and it'd be adding UI complexity. Boriss - thoughts?

Comment 17

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.