623289 - Inconsistent behavior of attachments

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect, P1)

Description

[Ayan Shah[:ashah]]

Saw this on stage - https://builder-addons-next.allizom.org
Env: Mac OS X and Windows 7, Firefox 4.0b8

STR:
1. Add attachments to your add-on code.(Add a .txt, .css and a .js file each)
2. Add some other attachments as well (like a .jpg etc)
3. Save your addon.
4. Go back to home page and do some random browsing on the website.
5. Come back to home page and click on "Source" button of the add-on that you had previously saved in step 3.

Actual result:
Some of the attachments are present, some are gone.

Expected result:
All the attachments should be present.

Comment 1

[Piotr Zalewa [:zalun]]

The URLs are not updated after adding attachment

It's visible if observing the Web Console.
[adding attachment A] POST
https://builder-addons-next.allizom.org/addon/add_attachment/1000103/revision/7/
revision number increased to 8
[adding attachment B] POST
https://builder-addons-next.allizom.org/addon/add_attachment/1000103/revision/7/
revision number increased to 9, but the attachment list was taken from 7 instead of 8

Comment 2

[Piotr Zalewa [:zalun]]

https://github.com/mozilla/FlightDeck/commit/b7546890dde7019af97b14be5d4afb09f28a8fcf

Comment 3

[Ayan Shah[:ashah]]

I can still see this happening on stage(https://builder-addons-next.allizom.org) and www.flightdeck.zalewa.info

Also, it looks like it does not update the right revision.

Comment 4

[Piotr Zalewa [:zalun]]

Yes - I'm sorry - I've closed the wrong bug

Comment 5

[Ayan Shah[:ashah]]

Verified on- https://builder-addons-next.allizom.org