623295 - BookmarksStore.wipe(): NS_ERROR_ILLEGAL_VALUE in nsINavBookmarksService.removeFolderChildren

Status: RESOLVED INVALID

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

A user reported this via email:

2011-01-05 14:01:00	Service.Main         DEBUG	Exception: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.removeFolderChildren] Stack trace: BStore_wipe()@bookmarks.js:1019 < Engine__wipeClient()@engines.js:280 < WrappedNotify()@util.js:147 < Engine_wipeClient()@engines.js:286 < anonymous()@service.js:1924 < WrappedNotify()@util.js:147 < WrappedCatch()@util.js:97 < WeaveSvc_wipeClient()@service.js:1909 < anonymous()@service.js:1592 < WrappedNotify()@util.js:147 < WrappedLock()@util.js:119 < WrappedCatch()@util.js:97 < sync()@service.js:1529 < anonymous()@service.js:554 < notify()@util.js:1126

Comment 1

[Richard Newman [:rnewman]]

Stale bug, ho!

Comment 2

[Richard Newman [:rnewman]]

A user just reported this on IRC.

1356638919280   Sync.Service       DEBUG  Exception: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.removeFolderChildren] Stack trace: BStore_wipe()@resource:///modules/services-sync/engines/bookmarks.js:1260 < Engine__wipeClient()@resource://services-sync/engines.js:498 < WrappedNotify()@resource://services-sync/util.js:142 < Engine_wipeClient()@resource://services-sync/engines.js:504 < onNotify()@resource:///modules/services-sync/service.js:1569 < WrappedNotify()@resource://services-sync/util.js:142 < wipeClient()@resource:///modules/services-sync/service.js:1554 < onNotify()@resource:///modules/services-sync/service.js:1252 < WrappedNotify()@resource://services-sync/util.js:142 < WrappedLock()@resource://services-sync/util.js:97 < _lockedSync()@resource:///modules/services-sync/service.js:1192 < resource:///modules/services-sync/service.js:1183 < WrappedCatch()@resource://services-sync/util.js:71 < sync()@resource:///modules/services-sync/service.js:1171

http://mozservices.pastebin.mozilla.org/2024382

Comment 4

[Richard Newman [:rnewman]]

Just talked to a user on IRC. We're seeing reports of this because the user encounters Bug 670069 -- that is, their bookmark DB loses a root -- and then they follow instructions[1] to Reset Sync, which involves calling wipeClient.

We should probably fix SUMO to *not* try Reset Sync, because I can't think of many situations in which it won't do more harm than good.


[1] https://support.mozilla.org/en-US/kb/firefox-sync-troubleshooting-and-tips#w_reset-your-sync-data

Comment 5

[Lina Butler (ex-Mozilla)]

We don't use `removeFolderChildren` anymore, and Places automatically replaces missing roots now (bug 478035).