623316 - Provide way to remove IndexedDB from content

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Doug Turner (:dougt)]

fennec will not ship IndexedDB in 4.0.  we need a prefable way of removing it from content similar to what we did with desktop notifications in firefox desktop.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

ben, jst suggested this approach.  Basically create a new interface for the indexedDB getter, and mark the existing one noscript.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

You should probably cache the return value of nsContentUtils::GetBoolPref().

Comment 3

[Doug Turner (:dougt)]

jst, bent suggested to just drop the old method.  any objections?

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 501717 [details] [diff] [review]
patch v.1

>+    DOM_CLASSINFO_MAP_ENTRY(nsIDOMStorageIndexedDB)
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMModalContentWindow)

I don't think ModalContentWindow needs IndexedDB...

>+nsGlobalWindow::GetOldIndexedDB(nsIIDBFactory** _retval)

Hopefully we can combine the getters on both interfaces to avoid this one in C++.

>+  static bool HasIndexedDBSupport() {
>+    return nsContentUtils::GetBoolPref("indexedDB.feature.enabled", PR_TRUE);

I'd actually default to PR_FALSE.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 501717 [details] [diff] [review]
patch v.1

Oh, and I was totally wrong earlier, I don't think we need to optimize the pref getter with a cache variable because nsDOMClassInfo::Init is only called once per app run. Before I thought that code would run every time we used the classinfo. Oops.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #4)
> Comment on attachment 501717 [details] [diff] [review]
> patch v.1
> 
> >+    DOM_CLASSINFO_MAP_ENTRY(nsIDOMStorageIndexedDB)
> >     DOM_CLASSINFO_MAP_ENTRY(nsIDOMModalContentWindow)
> 
> I don't think ModalContentWindow needs IndexedDB...
Why not?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #5)
>  earlier, I don't think we need to optimize the pref
> getter with a cache variable because nsDOMClassInfo::Init is only called once
> per app run.
Ah,  good. This is the information I was asking on IRC.

Comment 8

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 502552 [details] [diff] [review]
patch v.2

Can you add a comment to nsIDOMStorageWindow saying that the mozIndexedDB getter should be removed post-2.0?

Comment 10

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/477494ee0f88

Comment 11

[Aakash Desai [:aakashd]]

Are there any user-facing issues to test around with this landing, doug?

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

For Firefox, nothing should have changed. For Fennec, there should no longer be a "mozIndexedDB" property on window/the global object.