623404 - even more misc webgl test fixes!

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: error fixes

Some things (correctly, grumble) changed from INVALID_OPERATION -> INVALID_VALUE...

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 501518 [details] [diff] [review]
error fixes

>-    if (stride & requiredAlignmentMask) {
>+    if (stride && stride & requiredAlignmentMask) {
>         return ErrorInvalidOperation("VertexAttribPointer: stride doesn't satisfy the alignment "
>                                      "requirement of given type");
>     }

Why is that needed? As far as I can see this doesn't make any difference?

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 501518 [details] [diff] [review]
error fixes

r+ if comment 1 is addressed.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

whoops, yes, leftover that I didn't clean up.  No need for stride &&.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/e0c39c85ad47