even more misc webgl test fixes!

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch error fixesSplinter Review
Some things (correctly, grumble) changed from INVALID_OPERATION -> INVALID_VALUE...
Attachment #501518 - Flags: review?(bjacob)
Comment on attachment 501518 [details] [diff] [review]
error fixes

>-    if (stride & requiredAlignmentMask) {
>+    if (stride && stride & requiredAlignmentMask) {
>         return ErrorInvalidOperation("VertexAttribPointer: stride doesn't satisfy the alignment "
>                                      "requirement of given type");
>     }

Why is that needed? As far as I can see this doesn't make any difference?
Comment on attachment 501518 [details] [diff] [review]
error fixes

r+ if comment 1 is addressed.
Attachment #501518 - Flags: review?(bjacob) → review+
whoops, yes, leftover that I didn't clean up.  No need for stride &&.
http://hg.mozilla.org/mozilla-central/rev/e0c39c85ad47
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.