In Bugzilla 4.0, Message-ID is correctly generated for bugmails for new bugs. But it's gone in Bugzilla 4.1. When editing a bug, it's set correctly. Looks like a regression due to bug 65477. In BugMail::_generate_bugmail(), we have: my $email = new Email::MIME($msg_header); $msg_header correctly contains the Message-ID header, but $email->header('Message-ID'); says it's undefined. Note that this blocks my work on bug 419203, so I need a fix asap.
In my testing, it appears that the last line of $msg_header is ignored if it's not followed by a newline. The template has this trailing newline, but I suspect TT trims it as the template ends with [% ... %]. No idea why this only affects new bugs, though, and not existing bugs. If someone has a better fix, feel free to take the bug.
Assignee: email-notifications → LpSolit
Status: NEW → ASSIGNED
Attachment #501539 - Flags: review?(guy.pyrzak)
Attachment #501539 - Flags: review?(guy.pyrzak) → review?(dkl)
Comment on attachment 501539 [details] [diff] [review] patch, v1 Verified that the change in fact fixes the message id for new bug mails. r=dkl
Attachment #501539 - Flags: review?(dkl) → review+
Committing to: bzr+ssh://firstname.lastname@example.org/bugzilla/trunk/ modified Bugzilla/BugMail.pm Committed revision 7654.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.