623447 - "ASSERTION: AreDialogsBlocked() called without a top window"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: AreDialogsBlocked() called without a top window?: 'Error', file dom/base/nsGlobalWindow.cpp, line 2557

nsGlobalWindow::AreDialogsBlocked [dom/base/nsGlobalWindow.cpp:2559]
nsGlobalWindow::ShowModalDialog [dom/base/nsGlobalWindow.cpp:6712]
NS_InvokeByIndex_P [xptcinvoke_x86_64_unix.cpp:208]

This assertion was added as part of:

changeset:   e036427942ff
user:        Johnny Stenback
date:        Thu Sep 16 18:24:14 2010 -0700
summary:     Fixing bug 61098. Give users a way out of inifinite modal dialog loops. Original patch by Nochum Sossonko. r=[e-mail] a=beta7+

Comment 1

[Jesse Ruderman]

The testcase also triggers the assertion in bug 608191, which might have the same underlying cause.

Comment 2

[Nochum Sossonko [:Natch]]

Bogus assertion since we bail anyhow, but this seems like a result of removing the following line:

2.509 -  NS_ENSURE_TRUE(mDocShell, NS_ERROR_FAILURE);

from nsGlobalWindow::ShowModalDialog

Does this happen with alert/prompt/confirm dialogs, or only showModalDialog?

Comment 3

[Jesse Ruderman]

Attachment: testcase using alert

Yes, also happens with alert.

Comment 4

[Nochum Sossonko [:Natch]]

That would be because this line was removed:

http://mxr.mozilla.org/mozilla1.9.2/source/dom/base/nsGlobalWindow.cpp#4224

But that came before this bug. These are bogus, ::GetTop fails because there is no docshell.

Comment 5

[Nochum Sossonko [:Natch]]

Attachment: patch

This quiets the assert when there's no docshell, which is what used to happen before. We'll bail anyhow, because AreDialogsBlocked will return true.

Comment 6

[Nochum Sossonko [:Natch]]

Comment on attachment 501672 [details] [diff] [review]
patch

This is probably NPOTDB, but just to make sure a?....

Comment 7

[Nochum Sossonko [:Natch]]

http://hg.mozilla.org/mozilla-central/rev/5a420472acf6