This adds correct handling of the case where the copied rectangle is not contained in the framebuffer rectangle, and also adds some missing validation of function parameters. Makes the copy-tex-... test pass.
Assignee: nobody → bjacob
Status: NEW → ASSIGNED
Attachment #501703 - Flags: review?(vladimir)
Comment on attachment 501703 [details] [diff] [review] patch ah wait, there is a little mistake in there, will fix after lunch and update... (the tests are still all green, but they should be updated)
Attachment #501703 - Flags: review?(vladimir) → review-
This time it's ready
Summary: fix copy[Tex]SubImage2D → fix copyTex[Sub]Image2D
argh, forgot to hg qrefresh
Attachment #501756 - Flags: review?(vladimir) → review+
This looks like a step in the right direction, and I'll check it in, but there's something still broken in uninitialized-test.html. At one point it creates a 16x16 FBO, fills it with red, and then calls copyteximage2d from that FBO to a 512x512 texture. It expects the 16x16 region to be red and the rest black, but the entire texture seems to be ending up as black.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.