Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

This adds correct handling of the case where the copied rectangle is not contained in the framebuffer rectangle, and also adds some missing validation of function parameters. Makes the copy-tex-... test pass.
Posted patch patch (obsolete) — Splinter Review
Assignee: nobody → bjacob
Status: NEW → ASSIGNED
Attachment #501703 - Flags: review?(vladimir)
Attachment #501703 - Attachment is patch: true
Attachment #501703 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 501703 [details] [diff] [review]
patch

ah wait, there is a little mistake in there, will fix after lunch and update... (the tests are still all green, but they should be updated)
Attachment #501703 - Flags: review?(vladimir) → review-
Posted patch fix copyTex[Sub]Image2D (obsolete) — Splinter Review
This time it's ready
Attachment #501703 - Attachment is obsolete: true
Attachment #501738 - Flags: review?(vladimir)
Summary: fix copy[Tex]SubImage2D → fix copyTex[Sub]Image2D
argh, forgot to hg qrefresh
Attachment #501738 - Attachment is obsolete: true
Attachment #501756 - Flags: review?(vladimir)
Attachment #501738 - Flags: review?(vladimir)
This looks like a step in the right direction, and I'll check it in, but there's something still broken in uninitialized-test.html.  At one point it creates a 16x16 FBO, fills it with red, and then calls copyteximage2d from that FBO to a 512x512 texture.  It expects the 16x16 region to be red and the rest black, but the entire texture seems to be ending up as black.
http://hg.mozilla.org/mozilla-central/rev/d713275afd5d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.