Closed
Bug 623629
Opened 13 years ago
Closed 13 years ago
fix copyTex[Sub]Image2D
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
People
(Reporter: bjacob, Assigned: bjacob)
Details
Attachments
(1 file, 2 obsolete files)
11.41 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
This adds correct handling of the case where the copied rectangle is not contained in the framebuffer rectangle, and also adds some missing validation of function parameters. Makes the copy-tex-... test pass.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #501703 -
Attachment is patch: true
Attachment #501703 -
Attachment mime type: application/octet-stream → text/plain
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 501703 [details] [diff] [review] patch ah wait, there is a little mistake in there, will fix after lunch and update... (the tests are still all green, but they should be updated)
Attachment #501703 -
Flags: review?(vladimir) → review-
Assignee | ||
Comment 3•13 years ago
|
||
This time it's ready
Attachment #501703 -
Attachment is obsolete: true
Attachment #501738 -
Flags: review?(vladimir)
Assignee | ||
Updated•13 years ago
|
Summary: fix copy[Tex]SubImage2D → fix copyTex[Sub]Image2D
Assignee | ||
Comment 4•13 years ago
|
||
argh, forgot to hg qrefresh
Attachment #501738 -
Attachment is obsolete: true
Attachment #501756 -
Flags: review?(vladimir)
Attachment #501738 -
Flags: review?(vladimir)
Attachment #501756 -
Flags: review?(vladimir) → review+
This looks like a step in the right direction, and I'll check it in, but there's something still broken in uninitialized-test.html. At one point it creates a 16x16 FBO, fills it with red, and then calls copyteximage2d from that FBO to a 512x512 texture. It expects the 16x16 region to be red and the rest black, but the entire texture seems to be ending up as black.
http://hg.mozilla.org/mozilla-central/rev/d713275afd5d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•