default new contexts to a NULL compartment

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: [softblocker], fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
We currently default them to the default compartment, which seemed like a good idea at the time, but ends up being a total pain and it only hides bad bugs. With this change any bad selection of a compartment will cause a hard crash, so we can see it in opt builds.
(Assignee)

Comment 1

8 years ago
Created attachment 501894 [details] [diff] [review]
patch
Assignee: general → gal
(Assignee)

Comment 2

8 years ago
jorendorff, should we take this for 4?
(Assignee)

Comment 3

8 years ago
b? to get it on the radar, don't approve just yet please
blocking2.0: --- → ?
Andreas, have you decided what you want to do with this yet? (i.e., blocking status)
(Assignee)

Comment 5

8 years ago
We should land it.
(Assignee)

Updated

8 years ago
Attachment #501894 - Flags: review?(dmandelin)
(Assignee)

Updated

8 years ago
blocking2.0: ? → betaN+
Whiteboard: [softblocker]
Attachment #501894 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 6

8 years ago
http://hg.mozilla.org/tracemonkey/rev/57896fa8bb78
Whiteboard: [softblocker] → [softblocker], fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/57896fa8bb78
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.