Closed Bug 623893 Opened 10 years ago Closed 10 years ago

Middle clicking the back / forward buttons doesn't go back / forward

Categories

(Firefox :: General, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
Firefox 4.0b10
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.
blocking2.0: --- → ?
Attached patch patchSplinter Review
This introduces a 'delta' argument to duplicateTab, as pioneered by SeaMonkey. This is a backward compatible interface extension.
Attachment #501975 - Flags: review?(dietrich)
Blocks: 586068
Carrying over blocking from bug 617255.
blocking2.0: ? → betaN+
Comment on attachment 501975 [details] [diff] [review]
patch

>   /**
>    * Duplicates a given tab as thoroughly as possible.
>    *
>    * @param aWindow is the browser window into which the tab will be duplicated.
>    * @param aTab    is the tabbrowser tab to duplicate (can be from a different window).
>+   * @param aDelta  is the offset to the history entry that you want to load.

"entry to load in the duplicated tab" would be clearer.

>+  duplicateTab: function sss_duplicateTab(aWindow, aTab, aDelta) {
>     if (!aTab.ownerDocument || !aTab.ownerDocument.defaultView.__SSi ||
>         !aWindow.getBrowser)
>       throw (Components.returnCode = Cr.NS_ERROR_INVALID_ARG);
> 
>     var tabState = this._collectTabData(aTab, true);
>     var sourceWindow = aTab.ownerDocument.defaultView;
>     this._updateTextAndScrollDataForTab(sourceWindow, aTab.linkedBrowser, tabState, true);
>+    tabState.index += aDelta;

if there is an aDelta parameter passed in, should validate it.

r=me otherwise.
Attachment #501975 - Flags: review?(dietrich) → review+
What are the minimum and maximum indices? 1 and tabState.entries.length?
(In reply to comment #6)
> What are the minimum and maximum indices? 1 and tabState.entries.length?

hmm yeah, that looks right based on _collectTabData.
http://hg.mozilla.org/mozilla-central/rev/9862560161c4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
No longer blocks: FF2SM
You need to log in before you can comment on or make changes to this bug.