623949 - uninstalling bootstrapped extensions on android still needs a fennec restart

Status: RESOLVED INVALID

Description

[Tony Chung [:tchung]]

Created attachment 502022 [details]
uninstalling jetpack screenshot

using dietrich's jetpack test extension, uninstalling it (without restart) should remove the "H" in the bookmarks sidebar.  It only goes away after doing a fennec restart.

Test file: http://people.mozilla.com/~dietrich/install.html

See screenshot.  This was installed, uninstalled, and re-installed (which is why you see two instances of the H in the chrome).  Fennec restart was not initiated during this process.


Repro:
1) install android nightly: Mozilla/5.0 (Android; Linux armv71; rv:2.0b9pre) Gecko/20110107 Firefox/4.0b9pre Fennec/4.0b4pre	
2) install the test extension
3) allow the installer, and verify it gets installed (H appears in sidebar)
4) open addons manager, and uninstall the test extension (don't restart fennec)
5) Verify addons manager removes the test extension, but navigate back to bookmarks sidebar and H is still present. 
6) Restart Fennec, and you'll see the H's go away.

Expected:
- uninstalling bootstrapped extensions shouldnt require fennec to restart to pick up the changes

Actual:
- have to restart fennec if you want to see the uninstall changes.

Comment 1

[Tony Chung [:tchung]]

tested on a Nexus S

Comment 2

[Wesley Johnston (:wesj)]

Logging shows the shutdown and uninstall methods being called, so I'm wondering if this is just a bug in the addon. Jetpack makes the code a bit more difficult to read, so I'm adding dietrich to get his feedback.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I looked in the add-on XPI and I don't see any code that would remove the
button when the add-on is uninstalled. Therefore, the behavior you saw is
expected.

Dietrich can reopen if he expects the add-on the handle uninstall gracefully.

Comment 4

[Tony Chung [:tchung]]

ah okay, can you provide me a bootstrapped extension that changes the chrome and handles unistalling correctly?   I would like to add that to my testcases.   Thanks for investigating.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Created attachment 502050 [details]
simple bootstrap add-on

This add-on will install and uninstall without a restart

Comment 6

[Tony Chung [:tchung]]

(In reply to comment #5)
> Created attachment 502050 [details]
> simple bootstrap add-on
> 
> This add-on will install and uninstall without a restart


Actually, the addon is still not removing the test UI from the chrome when uninstalling nor disabling.   

It only works right when setting it to enable, or installing it on first try.

It might be better to take this test extension to another thread since this is already invalid.   should i file a new bug?