624148 - Middle clicking tab bar with tabs in title bar doesn't open a new tab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Gustavo Silva]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110108 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110108 Firefox/4.0b9pre

In the latest Minefield nightly (2011-01-08), tabs appear on the title bar by default. However, when middle clicking an empty space on that bar, nothing happens.

Reproducible: Always

Steps to Reproduce:
1. Middle click an empty space on the tab bar (tabs must be on title bar).
Actual Results:  
Nothing happens.

Expected Results:  
A new tab should be created.

Comment 1

[Grant]

Same for me, but with the menu bar on it still works.

Comment 2

[Csaba Kozák [:WonderCsabo]]

Confirmed

Comment 3

[:Felipe Gomes (needinfo for replies!)]

What is failing here is this check:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#3042

The originalTarget in this case is the parent scrollbox. This is due to pointer-events: none on the .scrollbox-innerbox. For the Aero theme the pointer-events: none on the #titlebar-spacer should be enough, I don't know about the other themes yet

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Classic/aero basic also behave well. Untested on Luna but I think it'll be the same. Dao do you have a XP vm to test this?

(By behaving well I'm assuming -> middle click for new tab, dbl click for restore window)

Comment 5

[Dão Gottwald [::dao]]

Comment on attachment 502658 [details] [diff] [review]
Patch

How does this handle double clicks?

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Double click is being handled automatically as a hit in non-client area through the use of the toolbar-drag binding, and the system performs the default action of restoring the window. But now that you mention it I'm not sure what's the case with XP.

Comment 7

[Dão Gottwald [::dao]]

Comment on attachment 502658 [details] [diff] [review]
Patch

Seems to works on XP.

>-#titlebar-spacer,
>-#main-window[tabsintitlebar]:not([inFullscreen]) .tabbrowser-arrowscrollbox > scrollbox > .scrollbox-innerbox {
>+#titlebar-spacer {
>   pointer-events: none;
> }
> 
> .tabbrowser-tab,
> .tabs-newtab-button {
>   pointer-events: auto;
> }

This change should make pointer-events: auto; for .tabbrowser-tab and .tabs-newtab-button unnecessary.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch v2

removed the redundant pointer-events

Comment 9

[:Felipe Gomes (needinfo for replies!)]

FWIW I've also tested this together with the patch from bug 624157

Comment 10

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/f5819377a399

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixes with Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre

Could we get an automated test for this feature?