I think we don't want anymore MOZ_COMPOSITED_PLUGINS MOZ_USE_IMAGE_EXPOSE and old obsolete dead maemo5 related code. suggesting kill that.
Created attachment 502272 [details] [diff] [review] Cleanup plugins code Tested with maemo5, maemo6.
Try build, seems fine http://hg.mozilla.org/try/rev/3bd2f64fe7df
Comment on attachment 502272 [details] [diff] [review] Cleanup plugins code see https://bugzilla.mozilla.org/show_bug.cgi?id=653201. Can you rebase on top?
Doug: Oleg wrote a patch and asked you for review. 4.5 months later you rewrite the patch, and then r- Oleg's patch, without bothering to comment on it. That's not good form.
Created attachment 534150 [details] [diff] [review] Updated patch Hope in next 4 month it will be reviewed :)
karlt, it isn't good form at all. I had a similar patch in my wip patch queue for a while (http://hg.mozilla.org/users/dougt_mozilla.com/wip/rev/50837673a66e) which I asked Josh to review. I totally forgot about this one. Sorry. rs+
patching file layout/generic/nsObjectFrame.cpp Hunk #1 FAILED at 184 Hunk #2 FAILED at 458 Hunk #5 FAILED at 586 Hunk #6 FAILED at 1502 Hunk #8 FAILED at 3187 Hunk #9 FAILED at 3270 Hunk #10 FAILED at 3511 Hunk #15 FAILED at 5613 Hunk #16 FAILED at 5702 Hunk #20 FAILED at 6354 Hunk #21 FAILED at 6617
The new patch is 16kb smaller, intentional?
part of this patch already landed in bug 653201
The changes are visible in the mozilla central repository. setting resolution to Verified Fixed.