Closed Bug 624165 Opened 13 years ago Closed 13 years ago

Cleanup plugins code, remove kill MOZ_COMPOSITED_PLUGINS and MOZ_USE_IMAGE_EXPOSE

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
ARM
Maemo
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla7

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(2 files, 1 obsolete file)

Updated patch
44.69 KB, patch
dougt
: review+
Details | Diff | Splinter Review
Updated to tip
28.33 KB, patch
Details | Diff | Splinter Review 
I think we don't want anymore MOZ_COMPOSITED_PLUGINS MOZ_USE_IMAGE_EXPOSE and old obsolete dead maemo5 related code.

suggesting kill that.
Attached patch Cleanup plugins code (obsolete) — — Splinter Review 
Tested with maemo5, maemo6.
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #502272 - Flags: review?(doug.turner)
Try build, seems fine
http://hg.mozilla.org/try/rev/3bd2f64fe7df
Comment on attachment 502272 [details] [diff] [review]
Cleanup plugins code

see https://bugzilla.mozilla.org/show_bug.cgi?id=653201.  Can you rebase on top?
Attachment #502272 - Flags: review?(doug.turner) → review-
Doug: Oleg wrote a patch and asked you for review.  4.5 months later you rewrite the patch, and then r- Oleg's patch, without bothering to comment on it.  That's not good form.
Attached patch Updated patch — — Splinter Review 
Hope in next 4 month it will be reviewed :)
Attachment #502272 - Attachment is obsolete: true
Attachment #534150 - Flags: review?(doug.turner)
Attachment #534150 - Flags: review?(doug.turner) → review+
karlt, it isn't good form at all.

I had a similar patch in my wip patch queue for a while (http://hg.mozilla.org/users/dougt_mozilla.com/wip/rev/50837673a66e) which I asked Josh to review.  I totally forgot about this one.  Sorry.

rs+
Keywords: checkin-needed
patching file layout/generic/nsObjectFrame.cpp
Hunk #1 FAILED at 184
Hunk #2 FAILED at 458
Hunk #5 FAILED at 586
Hunk #6 FAILED at 1502
Hunk #8 FAILED at 3187
Hunk #9 FAILED at 3270
Hunk #10 FAILED at 3511
Hunk #15 FAILED at 5613
Hunk #16 FAILED at 5702
Hunk #20 FAILED at 6354
Hunk #21 FAILED at 6617
Keywords: checkin-needed
Attached patch Updated to tip — — Splinter Review 

    
    

    
  
The new patch is 16kb smaller, intentional?

    
    

    
  
part of this patch already landed in bug 653201

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/projects/cedar/rev/48236642cb12
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7

    
    

    
  
Pushed:
http://hg.mozilla.org/mozilla-central/rev/48236642cb12
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar

    
    

    
  
The changes are visible in the mozilla central repository. setting resolution to Verified Fixed.
Status: RESOLVED → VERIFIED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.