Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Cleanup plugins code, remove kill MOZ_COMPOSITED_PLUGINS and MOZ_USE_IMAGE_EXPOSE

VERIFIED FIXED in mozilla7

Status

()

Core
Plug-ins
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla7
ARM
Maemo
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
I think we don't want anymore MOZ_COMPOSITED_PLUGINS MOZ_USE_IMAGE_EXPOSE and old obsolete dead maemo5 related code.

suggesting kill that.
(Assignee)

Comment 1

7 years ago
Created attachment 502272 [details] [diff] [review]
Cleanup plugins code

Tested with maemo5, maemo6.
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #502272 - Flags: review?(doug.turner)
(Assignee)

Comment 2

7 years ago
Try build, seems fine
http://hg.mozilla.org/try/rev/3bd2f64fe7df

Comment 3

6 years ago
Comment on attachment 502272 [details] [diff] [review]
Cleanup plugins code

see https://bugzilla.mozilla.org/show_bug.cgi?id=653201.  Can you rebase on top?
Attachment #502272 - Flags: review?(doug.turner) → review-
Doug: Oleg wrote a patch and asked you for review.  4.5 months later you rewrite the patch, and then r- Oleg's patch, without bothering to comment on it.  That's not good form.
(Assignee)

Comment 5

6 years ago
Created attachment 534150 [details] [diff] [review]
Updated patch

Hope in next 4 month it will be reviewed :)
Attachment #502272 - Attachment is obsolete: true
Attachment #534150 - Flags: review?(doug.turner)

Updated

6 years ago
Attachment #534150 - Flags: review?(doug.turner) → review+

Comment 6

6 years ago
karlt, it isn't good form at all.

I had a similar patch in my wip patch queue for a while (http://hg.mozilla.org/users/dougt_mozilla.com/wip/rev/50837673a66e) which I asked Josh to review.  I totally forgot about this one.  Sorry.

rs+
Keywords: checkin-needed
patching file layout/generic/nsObjectFrame.cpp
Hunk #1 FAILED at 184
Hunk #2 FAILED at 458
Hunk #5 FAILED at 586
Hunk #6 FAILED at 1502
Hunk #8 FAILED at 3187
Hunk #9 FAILED at 3270
Hunk #10 FAILED at 3511
Hunk #15 FAILED at 5613
Hunk #16 FAILED at 5702
Hunk #20 FAILED at 6354
Hunk #21 FAILED at 6617
Keywords: checkin-needed
(Assignee)

Comment 8

6 years ago
Created attachment 535127 [details] [diff] [review]
Updated to tip

Comment 9

6 years ago
The new patch is 16kb smaller, intentional?
(Assignee)

Comment 10

6 years ago
part of this patch already landed in bug 653201

Updated

6 years ago
Keywords: checkin-needed

Comment 11

6 years ago
http://hg.mozilla.org/projects/cedar/rev/48236642cb12
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
Pushed:
http://hg.mozilla.org/mozilla-central/rev/48236642cb12
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
The changes are visible in the mozilla central repository. setting resolution to Verified Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.