624176 - Leave a border on top of the new tabs-in-titlebar layout to support Aero drag-down-to-unmaximize

Status: RESOLVED DUPLICATE of bug 624129

(Firefox :: Theme, defect)

Description

[Benjamin Xiao]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110108 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110108 Firefox/4.0b9pre

A disadvantage with the new tabs-in-titlebar change that landed in today's nightly is that we can no longer drag the window down to unmaximize in Windows 7 if the tab bar is entirely full. Trying to do so results in tearing off a tab from the window. I suggest we leave a pixel or two of spacing between the tabs and the top of the window that users can use to drag the window down. Another suggestion would be to create an option for users to disable tabs-in-titlebar.

Reproducible: Always

Steps to Reproduce:
1. Fill up tab bar with tabs
2. Try to drag window down to unmaximize in Windows 7
3. Notice that we can't do this and instead end up tearing off a tab.
Actual Results:  
Unable to drag dowwn to unmaximize.

Expected Results:  
A one or two pixel spacing above tabs allows users to drag down to unmaximize.

Comment 1

[Luke Iliffe (Harlequin99)]

This discussion was largely had before implementation in the now closed bug 572160. 

There is a small space at either end of an full tabstrip to drag the window about; between the firefox button and the first tab, and between the panorama button and the minimise button.

To disable tabs in the title bar when maximised set browser.tabs.drawInTitlebar to false.

Comment 2

[Benjamin Xiao]

That defeats the whole purpose of Aero drag. If I wanted to aim at a small space, I might as well use the unmaximize button. The drag move in Windows 7 is supposed to make it easier and quicker.

Comment 3

[Luke Iliffe (Harlequin99)]

Adding dependency on bug 572160 for now to get visibility and feedback. 

However based on the UX team's stated desire for fitts law and the ability to push the mouse off the top of the screen and still select the tabs (i.e. infinite height tabs) I suspect this may be wontfixed. Need a UX person to make that decision.

Comment 4

[Mardeg]

This looks like a dupe of bug 624176 though that is worded badly.

Comment 5

[Majken Connor [:Kensie]]

Is this Bug 624129?

Mardeg think you commented the wrong bug number there ;)

Comment 6

[Marco Bonardo [:mak]]

asking for a border on top of tabs will always end up being wontfixed or duped to the first wontfix bugs for reasoning well explained in:
https://bugzilla.mozilla.org/show_bug.cgi?id=624129#c7

you could maybe ask to enlarge the space before/after tabs to make it easily clickable, but at that point you would have wasted space and still a smaller target area than the restore button.

Comment 7

[Majken Connor [:Kensie]]

(In reply to comment #6)
> asking for a border on top of tabs will always end up being wontfixed or duped
> to the first wontfix bugs for reasoning well explained in:
> https://bugzilla.mozilla.org/show_bug.cgi?id=624129#c7
> 
> you could maybe ask to enlarge the space before/after tabs to make it easily
> clickable, but at that point you would have wasted space and still a smaller
> target area than the restore button.
> 
> *** This bug has been marked as a duplicate of bug 624129 ***

Try that using a persona - it's quite ugly.  The sides and bottom of my frame take on the windows dictated border, but the top is entirely skinned. It's also kinda dumb to use the restore button to make a window the same size as maximized just to move the tabs... Is there a bug about a pref for tabs in titlebar when maximized?

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> Try that using a persona - it's quite ugly.  The sides and bottom of my frame
> take on the windows dictated border, but the top is entirely skinned. It's also
> kinda dumb to use the restore button to make a window the same size as
> maximized just to move the tabs...

I have a hard time understanding any of this.

Comment 9

[Majken Connor [:Kensie]]

Attachment: What firefox looks like not maximized

A screenshot of what I'm talking about. Maximize is prettier than this.

Comment 10

[Dão Gottwald [:dao]]

(In reply to comment #9)
> Created attachment 502603 [details]
> What firefox looks like not maximized
> 
> A screenshot of what I'm talking about. Maximize is prettier than this.

This doesn't seem to have anything to do with this bug.

Comment 11

[Majken Connor [:Kensie]]

Using the restore button has been proposed as a workaround. This screenshot is a reason why it's not a good one.

Comment 12

[Majken Connor [:Kensie]]

ah yeah, I interpreted the suggestion as leaving the window unmaximized which leaves the tabs out of the title bar so that you can use the titlebar. I see now the suggestion is run maximized and use the restore button, so my screenshot is unrelated as you pointed out.