624177 - Restoring a recently closed tab with a Reddit toolbar causes the main page to not load.(Restoring frames become empty)

Status: RESOLVED WORKSFORME

(Core :: DOM: Navigation, defect)

Description

[Benjamin Xiao]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110108 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110108 Firefox/4.0b9pre

If I close a webpage that has the Reddit toolbar and then later decide to restore that tab, all I see is the Reddit toolbar and not the main webpage that it's embedded in. This also happens if I restore a previous session.

Reproducible: Always

Steps to Reproduce:
1. Go to URL in bug report or any webpage with a Reddit toolbar
2. Close the tab or save-and-quit the session
3. Restore tab or session and note that the main webpage does not load and only the Reddit toolbar appears.
Actual Results:  
Upon restore, only reddit toolbar appears, not the main page

Expected Results:  
Upon restore, both the reddit toolbar and main webpage are loaded.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Seeing this with Mozilla/5.0 (Windows NT 5.1; rv:2.0b9pre) Gecko/20110107 Firefox/4.0b9pre ID:20110108005407. Fx 3.6.13 works.
BFCache Issue with Framesets?

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

Regressed within Beta 4 <-> 5.

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

Last good nightly: 2010-08-20 First bad nightly: 2010-08-21

Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c8c886655ea1&tochange=5c5c3bf8dfeb

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

For TM Branch (since above conatains a TM->MC Merge) the Range is
Last good nightly: 2010-08-23 First bad nightly: 2010-08-24

Pushlog: http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=14a90a53ceeb&tochange=fa851447f195

what also contains a Merge into the other Direction (MC->TM).

Also flipping image.mem.discardable (Bug 563088 was checked in) does not help.

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

As it seems, only Reddit Toolbar + Image-only Sites are related. Benjamin, can you confirm? 
Nominating for further Investigation. Hope this is okay.

Comment 6

[Benjamin Xiao]

No, this also happens on regular webpages with Reddit toolbar. Here's an example.
http://www.reddit.com/tb/ezgv2

Comment 7

[Alice0775 White]

The problem seems to be gone if I set "general.useragent.override" to "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20110111 Minefield/4.0b5pre".

Tested on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110109 Firefox/4.0b9pre ID:20110109030350

Comment 8

[Alice0775 White]

Sorry  please ignore comment #7, it fails sometimes even if UA spoofing.

Comment 9

[Alice0775 White]

OK I found regression range.

Regression window(cached houry):
Works:
http://hg.mozilla.org/mozilla-central/rev/7fb1bd5802f0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre ID:20100820150311
Fails:
http://hg.mozilla.org/mozilla-central/rev/cbf6e0a17783
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre ID:20100820190548
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7fb1bd5802f0&tochange=cbf6e0a17783

Suspected:
cbf6e0a17783	Olli Pettay — Bug 588643 - Crash in [@ nsDocShell::SetHistoryEntry ], r=bent/neil, a=blocking

Comment 10

[Benjamin Smedberg]

This sucks, but I don't think it's serious enough to stop-ship.

Comment 11

[Alice0775 White]

Attachment: sample html

After "Undo Close Tab", some frame empty.

Comment 12

[Benjamin Xiao]

In the latest builds, youtube sites with the reddit toolbar fail to load 100% of the time.

Comment 13

[Alice0775 White]

Fixed with fix of Bug 632835

I can not reproduce.
http://hg.mozilla.org/mozilla-central/rev/24714b2ebd4f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.2a1pre) Gecko/20110324 Firefox/4.2a1pre ID:20110324071048

Comment 14

[Benjamin Xiao]

I can not reproduce with the test URL with the latest hourly either. But youtube sites still fail to load with the Reddit toolbar.

Example URL: http://www.reddit.com/tb/ga0gm

Comment 15

[Alice0775 White]

I can confirm.

URL
http://www.reddit.com/tb/eyayq ; works

URL in Comment #6
http://www.reddit.com/tb/ezgv2 : Restoring a recently closed tab fails

URL in Comment 14
http://www.reddit.com/tb/ga0gm ; Initial loading fails

Comment 16

[Benjamin Xiao]

Odd, the second link works for me upon restore.

Comment 17

[Alice0775 White]

On recent Nigtli nightly
http://hg.mozilla.org/mozilla-central/rev/c72829d9cb2b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110615 Firefox/7.0a1 ID:20110615030754

URL
http://www.reddit.com/tb/eyayq ; works

URL in Comment #6
http://www.reddit.com/tb/ezgv2 ; works

URL in Comment 14
http://www.reddit.com/tb/ga0gm ; 
Firefox3.6,4.01,5.0, 6.0s2, 7.0a1 and Google Chrome12.0.742.100 fails to load. 
Firefox3.5.18 loads the page. 
Opera11.11 sgows error message as follows.
Error
http://www.youtube.com/watch?v=OivpEbe1Phc&feature=player_embedded
The website does not permit its content to be displayed in a frame. It must be displayed in a separate window.

Comment 18

[Alice0775 White]

The last one in comment #17 is duplication of Bug 664657 now.
So, I think this bug can be closed as WORKSFORME.

Comment 19

[Benjamin Xiao]

Yes I think so too. Closing as WFM.