Current Tasks filter should only show completed tasks if completed today

RESOLVED FIXED in 1.0b5

Status

Calendar
Tasks
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: mmecca, Assigned: mmecca)

Tracking

unspecified
1.0b5
x86
All

Details

Attachments

(3 attachments)

(Assignee)

Description

7 years ago
I think it makes sense to limit the completed tasks shown in the "Current Tasks" filter to those completed today. Tasks completed in the past aren't really current anymore, and the filter will become less usable over time as it fills up with old completed tasks.
(Assignee)

Comment 1

7 years ago
Created attachment 502308 [details] [diff] [review]
fix v1

Filters out tasks completed earlier than the current date.
Attachment #502308 - Flags: ui-review?(nisses.mail)
Attachment #502308 - Flags: review?(philipp)
Comment on attachment 502308 [details] [diff] [review]
fix v1

Wow, thats all thats needed? Doesn't the throughcurrent() method need to be hooked up somewhere? If not, then r=philipp

Andreas, do you agree this makes sense?
Attachment #502308 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

7 years ago
I think it would be good if we could take this for 1.0b4, if there are no objections.
No change since January. Maybe someone else could do the ui-review?
(Assignee)

Updated

7 years ago
Attachment #502308 - Flags: ui-review?(nisses.mail) → ui-review?(richard.marti)
(Assignee)

Comment 5

7 years ago
Created attachment 544149 [details]
Screenshot before patch
(Assignee)

Comment 6

7 years ago
Created attachment 544150 [details]
Screenshot with patch applied
Comment on attachment 502308 [details] [diff] [review]
fix v1

Review of attachment 502308 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense, tasks completed in the past aren't current.
Attachment #502308 - Flags: ui-review?(richard.marti) → ui-review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Target Milestone: --- → 1.0b5
http://hg.mozilla.org/comm-central/rev/640675ba244a

This has been committed on comm-central per the checkin-needed keyword. I'm not familiar with Lightning target milestones, so please do check the target milestone field is correct. If it's not, please tell me what to use next time :-).
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Since this changes the behavior of the filter, I'd suggest to keep it on trunk for now instead of pushing it into Lightning 1.0b5. Therefore everything is fine here. Richard, Matthew, any objections?


Jonathan, for next time: Trunk is totally correct if pushed to comm-central only. If its also pushed to another branch, then the corresponding Lightning version should be used (i.e comm-miramar = 1.0b5)
Target Milestone: 1.0b5 → Trunk
(Assignee)

Comment 10

6 years ago
The only reason I could see for pushing this to 1.0b5 is that, if I recall correctly, the recently released 1.0b4 was the first release to contain the Current Tasks filter, so changing it now would prevent users from getting used to the original behavior. Otherwise this isn't critical, so I'll leave it up to you.
Backported to comm-miramar  <http://hg.mozilla.org/releases/comm-miramar/rev/b64453c6cfcf> and <http://hg.mozilla.org/releases/comm-miramar/rev/cb5678d306db>
Target Milestone: Trunk → 1.0b5
You need to log in before you can comment on or make changes to this bug.