624211 - Current Tasks filter should only show completed tasks if completed today

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[Matthew Mecca [:mmecca]]

I think it makes sense to limit the completed tasks shown in the "Current Tasks" filter to those completed today. Tasks completed in the past aren't really current anymore, and the filter will become less usable over time as it fills up with old completed tasks.

Comment 1

[Matthew Mecca [:mmecca]]

Attachment: fix v1

Filters out tasks completed earlier than the current date.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 502308 [details] [diff] [review]
fix v1

Wow, thats all thats needed? Doesn't the throughcurrent() method need to be hooked up somewhere? If not, then r=philipp

Andreas, do you agree this makes sense?

Comment 3

[Matthew Mecca [:mmecca]]

I think it would be good if we could take this for 1.0b4, if there are no objections.

Comment 4

[Martin Schröder [:mschroeder]]

No change since January. Maybe someone else could do the ui-review?

Comment 5

[Matthew Mecca [:mmecca]]

Attachment: Screenshot before patch

Comment 6

[Matthew Mecca [:mmecca]]

Attachment: Screenshot with patch applied

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 502308 [details] [diff] [review]
fix v1

Review of attachment 502308 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense, tasks completed in the past aren't current.

Comment 8

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/comm-central/rev/640675ba244a

This has been committed on comm-central per the checkin-needed keyword. I'm not familiar with Lightning target milestones, so please do check the target milestone field is correct. If it's not, please tell me what to use next time :-).

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Since this changes the behavior of the filter, I'd suggest to keep it on trunk for now instead of pushing it into Lightning 1.0b5. Therefore everything is fine here. Richard, Matthew, any objections?


Jonathan, for next time: Trunk is totally correct if pushed to comm-central only. If its also pushed to another branch, then the corresponding Lightning version should be used (i.e comm-miramar = 1.0b5)

Comment 10

[Matthew Mecca [:mmecca]]

The only reason I could see for pushing this to 1.0b5 is that, if I recall correctly, the recently released 1.0b4 was the first release to contain the Current Tasks filter, so changing it now would prevent users from getting used to the original behavior. Otherwise this isn't critical, so I'll leave it up to you.

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Backported to comm-miramar  <http://hg.mozilla.org/releases/comm-miramar/rev/b64453c6cfcf> and <http://hg.mozilla.org/releases/comm-miramar/rev/cb5678d306db>