Closed Bug 624212 Opened 14 years ago Closed 14 years ago

Remove all inline JavaScript and move to external files

Categories

(Bugzilla :: Bugzilla-General, enhancement)

Product:
Bugzilla
Component:
Bugzilla-General
Version:
3.6.3
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 96983

People

(Reporter: reed, Unassigned)

Details

In order to fully-implement CSP (bug 600692), Bugzilla needs to have all its inline JavaScript moved to external files.
Bugzilla/Error.pm 199: <script type="text/javascript"> <!-- template/en/default/request/queue.html.tmpl 37:<script type="text/javascript"> template/en/default/search/boolean-charts.html.tmpl 51:<script type="text/javascript"> template/en/default/search/field.html.tmpl 66: <script type="text/javascript" defer="defer"> 103: <script type="text/javascript"> template/en/default/search/search-report-graph.html.tmpl 49:<script type="text/javascript"><!-- template/en/default/search/search-specific.html.tmpl 102: <script type="text/javascript"> <!-- template/en/default/search/form.html.tmpl 26:<script type="text/javascript"> 145: <script type="text/javascript"> <!-- 353: <script type="text/javascript"> 405: <script type="text/javascript"> template/en/default/search/search-create-series.html.tmpl 58:<script type="text/javascript"> template/en/default/admin/custom_fields/create.html.tmpl 35:<script type="text/javascript"> template/en/default/admin/params/common.html.tmpl 65: <script type="text/javascript"><!-- 72: <script type="text/javascript"><!-- 80: <script type="text/javascript"><!-- template/en/default/admin/workflow/edit.html.tmpl 24:<script type="text/javascript"> template/en/default/admin/workflow/comment.html.tmpl 24:<script type="text/javascript"> template/en/default/account/prefs/saved-searches.html.tmpl 28: <script type="text/javascript"><!-- template/en/default/account/prefs/email.html.tmpl 44:<script type="text/javascript"> template/en/default/account/auth/login-small.html.tmpl 71: <script type="text/javascript"> template/en/default/attachment/createformcontents.html.tmpl 60: <script type="text/javascript"> template/en/default/attachment/edit.html.tmpl 209: <script type="text/javascript"> 307: <script type="text/javascript"> template/en/default/attachment/create.html.tmpl 42:<script type="text/javascript"> template/en/default/attachment/list.html.tmpl 24:<script type="text/javascript"> template/en/default/attachment/diff-file.html.tmpl 48:<script type="text/javascript"> template/en/default/bug/knob.html.tmpl 73:<script type="text/javascript"> template/en/default/bug/comments.html.tmpl 123: <script type="text/javascript"><!-- template/en/default/bug/field.html.tmpl 78: <script type="text/javascript"> 95: <script type="text/javascript"> 153: <script type="text/javascript"> 188: <script type="text/javascript"> 199: <script type="text/javascript" defer="defer"> template/en/default/bug/edit.html.tmpl 33: <script type="text/javascript"> 307: <script type="text/javascript"> 375: <script type="text/javascript"> 482: <script type="text/javascript"> 525: <script type="text/javascript"> 581: <script type="text/javascript"> 839: <script type="text/javascript"> 959: <script type="text/javascript"> template/en/default/bug/create/create-guided.html.tmpl 52:<script type="text/javascript"> 192: <script type="text/javascript"> template/en/default/bug/create/create.html.tmpl 41:<script type="text/javascript"> 202: <script type="text/javascript"> 261: <script type="text/javascript"> 531: <script type="text/javascript"> 605: <script type="text/javascript"> 629: <script type="text/javascript"> template/en/default/bug/summarize-time.html.tmpl 344:<script type="text/javascript"> template/en/default/bug/edit.html.tmpl.orig 33: <script type="text/javascript"> 308: <script type="text/javascript"> 364: <script type="text/javascript"> 470: <script type="text/javascript"> 512: <script type="text/javascript"> 568: <script type="text/javascript"> 817: <script type="text/javascript"> 936: <script type="text/javascript"> template/en/default/global/header.html.tmpl 161: <script type="text/javascript"> template/en/default/global/per-bug-queries.html.tmpl 18: <script type="text/javascript"> template/en/default/global/code-error.html.tmpl 506: <script type="text/javascript"> <!-- template/en/default/global/userselect.html.tmpl 100: <script type="text/javascript"> template/en/default/global/help.html.tmpl 25: <script type="text/javascript"> <!-- template/en/default/list/quips.html.tmpl 138: <script type="text/javascript"><!-- template/en/default/list/edit-multiple.html.tmpl 31:<script type="text/javascript"> 326: <script type="text/javascript"> 440: <script type="text/javascript"> template/en/default/index.html.tmpl 40:<script type="text/javascript"> template/en/default/reports/series-common.html.tmpl 32:<script type="text/javascript"> template/en/default/reports/report-table.html.tmpl 48:<script type="text/javascript"> template/en/default/reports/create-chart.html.tmpl 36:<script type="text/javascript"> extensions/Voting/template/en/default/hook/admin/products/edit-common-rows.html.tmpl 53: <script type="text/javascript">
We will never be able to remove *all* the inline JS. Some of it has to do with passing template strings. Also, some of it is just short stuff that's specific to the page, or has to do with calling functions from scripts. In fact, I'd guess that that's most of the inline JS that's left, is stuff that has to be in the templates. BTW, I think that this bug is a dup.
No longer blocks: bz_csp
(In reply to comment #2) > We will never be able to remove *all* the inline JS. We'll find a way. It has to be done for CSP. :)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Whiteboard: [wanted-bmo][sg:want]
Target Milestone: Bugzilla 4.2 → ---
You need to log in before you can comment on or make changes to this bug.