624229 - add API to enable/disable per-compartment GCs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Andreas Gal :gal]

Attachment: draft patch

Comment 2

[Andreas Gal :gal]

Attachment: draft patch, v2

Comment 3

[Andreas Gal :gal]

Attachment: patch

Comment 4

[Andreas Gal :gal]

brendan, if you can review the pref setting code as well, feel free to clear the review request for jst

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 502426 [details] [diff] [review]
patch

>+static int
>+SetMemoryGCModePrefChangedCallback(const char* aPrefName, void* aClosure)

I don't know why memory is in these names, but it seems to be all over!

>diff --git a/js/src/jsapi.cpp b/js/src/jsapi.cpp
>--- a/js/src/jsapi.cpp
>+++ b/js/src/jsapi.cpp
>@@ -2592,16 +2592,19 @@ JS_SetGCParameter(JSRuntime *rt, JSGCPar
>         rt->gcMaxBytes = value;
>         break;
>       case JSGC_MAX_MALLOC_BYTES:
>         rt->setGCMaxMallocBytes(value);
>         break;
>       case JSGC_STACKPOOL_LIFESPAN:
>         rt->gcEmptyArenaPoolLifespan = value;
>         break;
>+      case JSGC_MODE:
>+        rt->gcMode = JSGCMode(value);
>+        break;

Check (or at least assert) that value is in the legal range.

>+typedef enum JSGCMode {
>+    /* Perform only global GCs. */
>+    JSGC_STOP_THE_WORLD_ONLY = 0,

JSGC_MODE_GLOBAL and JSGC_MODE_COMPARTMENT?  "Stop the world" is a separate concept, more related to mutator
blocking than separation of heaps and collection, IMO.

>+    /* Perform per-compartment GCs until too much garbage has accumulated. */
>+    JSGC_PER_COMPARTMENT = 1
>+} JSGCMode;
>+

r=shaver with those changes.

Comment 6

[Brendan Eich [:brendan]]

Nice review, shaver!

/be

Comment 7

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/de9053031560

Comment 8

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/de9053031560