624267 - Crash on Ubuntu [@ nsGNOMEShellService::SetDefaultBrowser ]

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Scoobidiver (away)]

It is #1 top crasher on Linux in 4.0b8 for the last week.

Comments say:
"crashed when i tried to access "manage add ons..." button in the preferences window."
"New installation of Ubuntu Natty - 11.04 testing. Answered 'yes' to 'do you want to set Firefox' as default browser and crash occurred immediately. Note that 11.04 is far from being stable."
"when updated beta 7 for beta8"

Signature	nsGNOMEShellService::SetDefaultBrowser
UUID	0c2a2a27-2037-4496-9680-526c52110108
Time 	2011-01-08 16:45:39.322473
Uptime	18
Install Age	18 seconds since version was first installed.
Product	Firefox
Version	4.0b8
Build ID	20110105201936
Branch	2.0
OS	Linux
OS Version	0.0.0 Linux 2.6.37-7-generic #19-Ubuntu SMP Tue Nov 30 23:46:45 UTC 2010 i686
CPU	x86
CPU Info	GenuineIntel family 15 model 2 stepping 9
Crash Reason	SIGSEGV
Crash Address	0x0

Frame 	Module 	Signature [Expand] 	Source
0 	libbrowsercomps.so 	nsGNOMEShellService::SetDefaultBrowser 	nsGNOMEShellService.cpp:287
1 	libxul.so 	libxul.so@0xccbf0e 	
2 	libxul.so 	XPCWrappedNative::CallMethod 	xpcwrappednative.cpp:3064
3 	libxul.so 	XPC_WN_CallMethod 	xpcwrappednativejsops.cpp:1588
4 	libxul.so 	js::Interpret 	jscntxtinlines.h:684
5 	libxul.so 	js::Invoke 	jsinterp.cpp:657
6 	libxul.so 	js::ExternalInvoke 	jsinterp.cpp:858
7 	libxul.so 	JS_CallFunctionValue 	jsinterp.h:962
8 	libxul.so 	nsJSContext::CallEventHandler 	nsJSEnvironment.cpp:2177
9 	libxul.so 	nsGlobalWindow::RunTimeout 	nsGlobalWindow.cpp:8966
10 	libxul.so 	nsGlobalWindow::TimerCallback 	nsGlobalWindow.cpp:9311
11 	libxul.so 	nsTimerImpl::Fire 	nsTimerImpl.cpp:425
12 	libxul.so 	nsTimerEvent::Run 	nsTimerImpl.cpp:517
13 	libxul.so 	nsThread::ProcessNextEvent 	nsThread.cpp:626
14 	libxul.so 	NS_ProcessNextEvent_P 	nsThreadUtils.cpp:250
15 	libxul.so 	mozilla::ipc::MessagePump::Run 	MessagePump.cpp:110
16 	libxul.so 	MessageLoop::RunInternal 	message_loop.cc:219
17 	libxul.so 	MessageLoop::Run 	message_loop.cc:202
18 	libxul.so 	nsBaseAppShell::Run 	nsBaseAppShell.cpp:192
19 	libxul.so 	nsAppStartup::Run 	nsAppStartup.cpp:191
20 	libxul.so 	XRE_main 	nsAppRunner.cpp:3691
21 	firefox-bin 	main 	nsBrowserApp.cpp:158
22 	libc-2.12.1.so 	libc-2.12.1.so@0x16ce6 	
23 	firefox-bin 	firefox-bin@0x10e0 	
24 	firefox-bin 	Output 	nsBrowserApp.cpp:77
25 	ld-2.12.1.so 	ld-2.12.1.so@0xeabf 	

More reports at:
http://crash-stats.mozilla.com/report/list?product=Firefox&platform=linux&query_search=signature&query_type=exact&query=&range_value=2&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=nsGNOMEShellService%3A%3ASetDefaultBrowser

Comment 1

[timeless]

208 nsGNOMEShellService::SetDefaultBrowser(PRBool aClaimAllTypes,
216   nsCOMPtr<nsIGConfService> gconf = do_GetService(NS_GCONFSERVICE_CONTRACTID);

222   for (i = 0; i < NS_ARRAY_LENGTH(appProtocols); ++i) {
223     if (appProtocols[i].essential || aClaimAllTypes) {
224       gconf->SetAppForProtocol(nsDependentCString(appProtocols[i].name),

No check for gconf?

252       giovfs->CreateAppFromCommand(mAppPath,
253                                 id,
254                                 getter_AddRefs(appInfo));
256       // Add mime types for html, xhtml extension and set app to just created appinfo.
257       for (i = 0; i < NS_ARRAY_LENGTH(appTypes); ++i) {
258         appInfo->SetAsDefaultForMimeType(nsDependentCString(appTypes[i].mimeType));
259         appInfo->SetAsDefaultForFileExtensions(nsDependentCString(appTypes[i].extensions));

and no check for appInfo

Comment 2

[timeless]

Attachment: proposal

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/f518eb4285bf

Comment 4

[Dietrich Ayala (:dietrich)]

Topcrasher -> blocking+. Bonus ouch points for crashing while a user tries to set Firefox as the default browser.