624287 - Small space above tabs looks cut off when using persona

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Majken Connor [:Kensie]]

Using a persona means that I can see a tiny bit of the image above the tabs, but it's so small my brain makes it feel like it's not intended, that the top of the browser is being cut off. Using the default theme, my window bar is dark purple and so the tabs to seem to go to the top of my screen (the purple blends into the black casing).  Given that personas are pretty heavily promoted, it would be nice to add 1 or 2 pixels to make the gap look more intentional.

I'm currently using persona fractal vilja_2 by candelora but it feels squished on the other personas I checked out as well.

Comment 1

[Asa Dotzler [:asa]]

I don't think this is really a bug. I've just tried a dozen personas of varying colors and contrasts and I don't think it looks odd at all. If it is a problem, I can't imagine that the solution is to pad it more. cc'ing a couple of ux folks for their opinion.

Comment 2

[Majken Connor [:Kensie]]

It's because the padding is so miniscule in relation to the rest of the padding. I guess it's the same as the space between tabs, but it's smaller than the space between the minefield button and the toolbar, and less than the space between the toolbar edge and the URL bar. I think it's even less than the space between the back button and the toolbar edges.

However I think a bunch of these bugs are solved by a visible "tabs in titlebar" preference. Right now my persona is defeated, but if I unmaximize the window it's pretty again, except the rest of the browser is not.

That said, we've increased padding before because things looked too cramped.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

we want to be sure that users realize that they can hit the mouse against the screen edge to activate a tab.  The more space we put in the more likely they are to very slowly and carefully target each tab instead of just shooting for a target off screen.

Comment 4

[Majken Connor [:Kensie]]

Then why not kill the space altogether?

Comment 5

[Csaba Kozák [:WonderCsabo]]

(In reply to comment #4)
> Then why not kill the space altogether?

Because that would look bad, i guess.

Comment 6

[[not reading bugmail]]

Not to mention, we know the current small space exists so we can use Aero Snap features in Windows 7 and use other window operations, but I agree if was a bit bigger, that might make it look cleaner, but I don't believe removing is what we want either and we would lose the ability to use said features.

Comment 7

[Majken Connor [:Kensie]]

(In reply to comment #6)
> Not to mention, we know the current small space exists so we can use Aero Snap
> features in Windows 7 and use other window operations, but I agree if was a bit
> bigger, that might make it look cleaner, but I don't believe removing is what
> we want either and we would lose the ability to use said features.

Actually, that's not why it's there. See the other bugs about new tab behaviour breaking Aero snap. Devs are allowing chrome on either side of the tab strip for use with Aero snap.

Comment 8

[Mark Banner (:standard8)]

We stopped calling the theme based "Personas" that name several years back, when they were also integrated into normal themes in Firefox.

Therefore bulk-closing Persona related bugs as they are no longer valid. If you are still having a potentially related issue in the latest version of Firefox, please take a look on our support site (https://support.mozilla.org) or file a new issue.