Closed
Bug 624324
Opened 14 years ago
Closed 14 years ago
trychooser with "-b d -u foo" only actually does foo on Windows
Categories
(Release Engineering :: General, defect, P1)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: lsblakk)
Details
(Whiteboard: [tryserver])
Attachments
(1 file)
15.67 KB,
patch
|
catlee
:
review+
lsblakk
:
checked-in+
|
Details | Diff | Splinter Review |
Inspired by Taras' results from http://hg.mozilla.org/try/rev/954754913a8d and http://hg.mozilla.org/try/rev/0626369005a2 where "try: -b d -p all -u mochitest-o -t none" only actually got a test run on Windows, http://hg.mozilla.org/try/rev/8e4720344a75 is an even more simplified "try: -b d -u mochitest-1" which only actually got a test run on Windows.
Updated•14 years ago
|
Assignee: nobody → lsblakk
Whiteboard: [
Comment 1•14 years ago
|
||
Phil, thanks for filing this for me
Assignee | ||
Comment 2•14 years ago
|
||
Upgraded the unittests to catch that in fact the addition of looking for '-debug' in order to get all either opt/debug for builds meant that for unittest pretty names which do not use '-debug' but instead are built inside try_parser with buildType any try syntax for unittests with debug only would only get the win32 on the builder master.
This patch fixes the issue, and also has a few more unittests adding more than just win32 for unittests on the test-master functionality to better catch issues.
Attachment #502538 -
Flags: review?(catlee)
Assignee | ||
Updated•14 years ago
|
Priority: -- → P1
Whiteboard: [ → [tryserver]
Updated•14 years ago
|
Attachment #502538 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 502538 [details] [diff] [review]
[tested] assigns 'all' platforms differently for builders v. testers in try_parser
http://hg.mozilla.org/build/buildbotcustom/rev/1a012ec074e6 - landed on default to test in preproduction before merge to production with reconfig.
Attachment #502538 -
Flags: checked-in+
Assignee | ||
Comment 4•14 years ago
|
||
This has landed in production.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•