624324 - trychooser with "-b d -u foo" only actually does foo on Windows

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Phil Ringnalda (:philor)]

Inspired by Taras' results from http://hg.mozilla.org/try/rev/954754913a8d and http://hg.mozilla.org/try/rev/0626369005a2 where "try: -b d -p all -u mochitest-o -t none" only actually got a test run on Windows, http://hg.mozilla.org/try/rev/8e4720344a75 is an even more simplified "try: -b d -u mochitest-1" which only actually got a test run on Windows.

Comment 1

[(dormant account)]

Phil, thanks for filing this for me

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: [tested] assigns 'all' platforms differently for builders v. testers in try_parser

Upgraded the unittests to catch that in fact the addition of looking for '-debug' in order to get all either opt/debug for builds meant that for unittest pretty names which do not use '-debug' but instead are built inside try_parser with buildType any try syntax for unittests with debug only would only get the win32 on the builder master.

This patch fixes the issue, and also has a few more unittests adding more than just win32 for unittests on the test-master functionality to better catch issues.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 502538 [details] [diff] [review]
[tested] assigns 'all' platforms differently for builders v. testers in try_parser

http://hg.mozilla.org/build/buildbotcustom/rev/1a012ec074e6 - landed on default to test in preproduction before merge to production with reconfig.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

This has landed in production.