624414 - The "Possible duplicates" table in enter_bug.cgi no longer works (BUGZILLA.value_descs is undefined)

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

As bug 595410 moved value_descs inside [% IF in_template_var %] [% END %], the display_value() function in js/global.js can no longer access it, meaning that BUGZILLA.value_descs set in global/header.html.tmpl is now undefined, and the "Possible duplicates" table in enter_bug.cgi no longer works.

Error : BUGZILLA.value_descs[field] is undefined
Source File : https://localhost/bugzilla/js/global.js
Line : 126

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This fixes the problem, which was (a) that value-descs.js.tmpl couldn't get at the "value_descs" hash anymore and (b) my patch that put value_descs into the "in_template_var" patch had a bug that prevented value_descs from actually getting into "vars".

Comment 2

[Max Kanat-Alexander]

BTW, this is a "blocker" for 4.1.1.

Comment 3

[:glob ✱]

Comment on attachment 516199 [details] [diff] [review]
v1

r=glob

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified template/en/default/global/field-descs.none.tmpl
modified template/en/default/global/header.html.tmpl
modified template/en/default/global/value-descs.js.tmpl
added template/en/default/global/value-descs.none.tmpl
Committed revision 7733.

Comment 5

[Frédéric Buclin]

Note that there is no need to CC me on a bug I filed. I'm already watching it. ;)