624436 - "Aborting due to channel inactivity" should surface as network error, not Unknown Error

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Jesse]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13

Error while syncing

Reproducible: Always

Comment 1

[Philipp von Weitershausen [:philikon]]

Please go to about:sync-log, save it to a file and attach it here. Thanks!

Comment 2

[Jesse]

Attachment: sync log 01-10-2011

Comment 3

[Philipp von Weitershausen [:philikon]]

Thanks for the log. The problem is this:

2011-01-10 01:51:44	Service.Main         DEBUG	bookmarks failed: Aborting due to channel inactivity. JS Stack trace: abortRequest([object Object])@resource.js:466 < notify([object XPCWrappedNative_NoHelper])@util.js:1126 < Res__request(...)@resource.js:357 < Res_get()@resource.js:376 < SyncEngine__processIncoming()@engines.js:511 < _processIncoming()@bookmarks.js:212 < ()@engines.js:203 < SyncEngine__sync()@engines.js:768 < wrappedSync(null)@util.js:168 < runInBatchMode([object Object],null)@:0 < batchedSync()@util.js:174 < ()@engines.js:203 < WrappedNotify()@util.js:147 < Engine_sync()@engines.js:213 < WeaveSvc__syncEngine([object Object])@service.js:1738 < ()@service.js:1624 < WrappedNotify()@util.js:147 < WrappedLock()@util.js:119 < WrappedCatch()@util.js:97 < sync(false)@service.js:1529 < ([object Object])@service.js:554 < notify([object XPCWrappedNative_NoHelper])@util.js:1126

It looks like the request is timing out. Can you reproduce this problem on various kinds of networks?

Comment 4

[Jesse]

This "Error While Syncing" happens on my home network in PA running Win7 OS. 
I don't get this error at my mother's house in NY, on a WinXP OS.

Comment 5

[Philipp von Weitershausen [:philikon]]

Sounds like it's just a network issue then, though we should really have good error reporting here. What does it say next to "Error while syncing"?

Comment 6

[Jesse]

"Sync encountered an error while syncing: Unknown error. Sync will automatically "

I'll take the laptop over to my mother's house, and try it over there.
Thank you for looking into this.

Jesse

Comment 7

[Jesse]

Ooops

"Sync encountered an error while syncing: Unknown error. Sync will
automatically retry this action."

Comment 8

[Philipp von Weitershausen [:philikon]]

(In reply to comment #6)
> "Sync encountered an error while syncing: Unknown error. Sync will
> automatically "

Yeah, Unknown Error is not super helpful. I'm morphing this bug into fixing the error message.

Comment 9

[Jesse]

Follow up:
Just tried the laptop on network at my mother's house. Same error with FireFox sync. 

Desktop computer FireFox Sync working; just finished updating.

Therefore network is not the factor in sync error. Only difference is in the OS: fail with Win7, success with WinXP.

Comment 10

[Richard Newman [:rnewman]]

(In reply to comment #9)

> Therefore network is not the factor in sync error. Only difference is in the
> OS: fail with Win7, success with WinXP.

That's ten years of network stack changes... it's entirely possible that it's a network symptom that you just don't see with WinXP. Or the Win7 machine is a laptop on WiFi, but the desktop is wired.

Still, the obvious problem here is that a network error (that's the error Sync is receiving from the rest of Firefox) doesn't display as such, so that's what we'll fix...

Comment 11

[Marina Samuel [:emtwo]]

Attachment: test that network timeout results in correct network error bit being set

Comment 12

[Marina Samuel [:emtwo]]

Attachment: test that network timeout results in correct network error bit being set

Comment 13

[Philipp von Weitershausen [:philikon]]

Landed test on s-c with some fixes to make the test actually pass: http://hg.mozilla.org/services/services-central/rev/9f216b242b6a

Comment 14

[Jesse]

Attachment: Sync Log 05-21-2011

Sync fail 05-21-2011, added latest about:sync-log
Last date shown in log: 2011-03-26 09:08:19. Why?

Comment 15

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/9f216b242b6a