624630 - [JS Error] browser_addons.js message listener is stuck and UIReadyDelayed is busted

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

The following error keeps happening all through the browser-chrome test suite. It looks like the message handler is never fully removed, so every "pageshow" is firing the message handler - which is now invalid, since the test is long over.

JavaScript error: chrome://mochitests/content/browser/mobile/chrome/browser_addons.js, line 291: gCurrentTab.browser is null

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I also see issues with FormHelper and FindHelper. It looks like we are not making it all the way through the BrowserUI.UIReadyDelayed code.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Found the UIReadyDelayed issue. Bustage from bug 620975. nsIAlertsProgressListener.onCancel is impl'ed on other platforms, buts throws. We need to wrap the code in #ifdef ANDROID.

The browser_adons.js stuck message handler is fixed if we add the tab first and use a setTimeout(...0) for the callback.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Fixes. Tests are green locally with this.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 502729 [details] [diff] [review]
patch

I'm landing this to fix the bustage from bug 620975, but please review for sanity.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/357e6c83a17b

Comment 6

[Andreea Pod]

Verified fixed according to Tinderboxpushlog results