Closed Bug 624630 Opened 9 years ago Closed 9 years ago

[JS Error] browser_addons.js message listener is stuck and UIReadyDelayed is busted

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

The following error keeps happening all through the browser-chrome test suite. It looks like the message handler is never fully removed, so every "pageshow" is firing the message handler - which is now invalid, since the test is long over.

JavaScript error: chrome://mochitests/content/browser/mobile/chrome/browser_addons.js, line 291: gCurrentTab.browser is null
I also see issues with FormHelper and FindHelper. It looks like we are not making it all the way through the BrowserUI.UIReadyDelayed code.
Summary: [JS Error] browser_addons.js message listener is stuck → [JS Error] browser_addons.js message listener is stuck and UIReadyDelayed is busted
Found the UIReadyDelayed issue. Bustage from bug 620975. nsIAlertsProgressListener.onCancel is impl'ed on other platforms, buts throws. We need to wrap the code in #ifdef ANDROID.

The browser_adons.js stuck message handler is fixed if we add the tab first and use a setTimeout(...0) for the callback.
Attached patch patchSplinter Review
Fixes. Tests are green locally with this.
Assignee: nobody → mark.finkle
Comment on attachment 502729 [details] [diff] [review]
patch

I'm landing this to fix the bustage from bug 620975, but please review for sanity.
Attachment #502729 - Flags: review?(21)
pushed:
http://hg.mozilla.org/mobile-browser/rev/357e6c83a17b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed according to Tinderboxpushlog results
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.