Closed Bug 624648 Opened 12 years ago Closed 12 years ago

IAccessible::get_accChild broken for child indices

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b10
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: surkov, Assigned: surkov)

References

Details

(Keywords: access, regression, Whiteboard: [hardblocker])

Attachments

(1 file)

patch
793 bytes, patch
davidb
: review+
Details | Diff | Splinter Review 
request a blocking as regression from betas.
blocking2.0: --- → ?
Attached patch patch — — Splinter Review 
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED

        Attachment #502746 -
        Flags: review?(bolterbugz)

    
    

    
  
Comment on attachment 502746 [details] [diff] [review]
patch

>+  // Gecko child indices are 0-based in contrast to indices used in MSAA.

Might as well be explicit:
// Gecko child indices are 0-based and MSAA child indices are 1-based.

        Attachment #502746 -
        Flags: review?(bolterbugz) → review+

    
    

    
  
Thanks for jumping on this one Alexander. Approving blocking since this is major.
blocking2.0: ? → final+

    
  
Whiteboard: [hardblocker]

    
    

    
  
landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/a659f574f159
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10

    
    

    
  
(In reply to comment #3)
> Comment on attachment 502746 [details] [diff] [review]
> patch
> 
> >+  // Gecko child indices are 0-based in contrast to indices used in MSAA.
> 
> Might as well be explicit:
> // Gecko child indices are 0-based and MSAA child indices are 1-based.

Forgot to change the comment, hope that's ok.

    
    

    
  
Verified fixed via Sylvain on the mailing list.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.