Last Comment Bug 624718 - Use contentprefs caching for zoom
: Use contentprefs caching for zoom
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: unspecified
: All All
: -- normal (vote)
: seamonkey2.1b2
Assigned To: Robert Kaiser (not working on stability any more)
:
Mentors:
Depends on: 559992
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-11 07:03 PST by Robert Kaiser (not working on stability any more)
Modified: 2011-01-18 21:15 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
take a shortcut when pref is cached (1.42 KB, patch)
2011-01-11 07:46 PST, Robert Kaiser (not working on stability any more)
neil: review+
Details | Diff | Review

Description Robert Kaiser (not working on stability any more) 2011-01-11 07:03:55 PST
Bug 559992 added a caching system for content prefs and used it for Firefox zoom, we should do the latter in SeaMonkey as well.
http://hg.mozilla.org/mozilla-central/rev/9365fe1a3165 is the relevant checkin, we only need to port the browser-fullZoom.js part into our view "zoom overlay".
Comment 1 Robert Kaiser (not working on stability any more) 2011-01-11 07:46:21 PST
Created attachment 502802 [details] [diff] [review]
take a shortcut when pref is cached

From all I see, the actual change in this ported code is just that we don't need to re-check when the pref is cached, as we know it will be fast in that case.
Comment 2 Robert Kaiser (not working on stability any more) 2011-01-18 10:02:38 PST
Pushed as http://hg.mozilla.org/comm-central/rev/dec8d99ccc4b
Comment 3 Philip Chee 2011-01-18 21:15:55 PST
Can we use .bind(this) here?

Note You need to log in before you can comment on or make changes to this bug.