Last Comment Bug 624718 - Use contentprefs caching for zoom
: Use contentprefs caching for zoom
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: unspecified
: All All
: -- normal (vote)
: seamonkey2.1b2
Assigned To: Robert Kaiser
Depends on: 559992
  Show dependency treegraph
Reported: 2011-01-11 07:03 PST by Robert Kaiser
Modified: 2011-01-18 21:15 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

take a shortcut when pref is cached (1.42 KB, patch)
2011-01-11 07:46 PST, Robert Kaiser
neil: review+
Details | Diff | Splinter Review

Description Robert Kaiser 2011-01-11 07:03:55 PST
Bug 559992 added a caching system for content prefs and used it for Firefox zoom, we should do the latter in SeaMonkey as well. is the relevant checkin, we only need to port the browser-fullZoom.js part into our view "zoom overlay".
Comment 1 Robert Kaiser 2011-01-11 07:46:21 PST
Created attachment 502802 [details] [diff] [review]
take a shortcut when pref is cached

From all I see, the actual change in this ported code is just that we don't need to re-check when the pref is cached, as we know it will be fast in that case.
Comment 2 Robert Kaiser 2011-01-18 10:02:38 PST
Pushed as
Comment 3 Philip Chee 2011-01-18 21:15:55 PST
Can we use .bind(this) here?

Note You need to log in before you can comment on or make changes to this bug.