http://html5.validator.nu/?doc=http%3A%2F%2Fwww.mozilla.com%2Fen-US%2Fplugincheck%2F The page does not validate
A few quick validation fixes in trunk in r81212. Still have to sort out the Qtip jquery plugin validation errors.
Has someone filed a ticket for the js lib?
(In reply to comment #2) > Has someone filed a ticket for the js lib? If only it were that easy. The project home page (http://craigsworks.com/projects/qtip/) points to project hosting on LaunchPad (https://launchpad.net/qtip). The LauchPad page says that it was moved to GitHub in July of 2010: http://github.com/Craga89/qTip/ That GitHub page is a 404 (an awesome 404, mind you), but that same user has a project on GitHub for "qTip2": https://github.com/Craga89/qTip This minor validation issue probably isn't worth upgrading to a new major version of a js lib, but if the old one is abandoned, it might be necessary at some point. I've sent a message to the GitHub project owner asking for clarification.
Thanks for the update Steven. As discussed in this mornings meeting I'm going to take this bug out of this release for now and add it to a future release since it seems pretty low impact. Let me know if anyone thinks otherwise.
Target Milestone: 1.1 → 1.7
Heard back from the qTip developer (https://github.com/Craga89) - quick helpful: The 1.0 branch of qTip is indeed dead. 2.0 is backwards compatible with a tool to convert code from 1.0 -> 2.0: http://craigsworks.com/projects/qtip2/converter/ Also, apparently the invalid HTML in question isn't even supposed to be in there - the JS generates it dynamically. The problem is, I can't actually see any tooltips on this page so I can't test after removing it.
Hey Steven, Craig here :) The tooltip shows up when you have an "insecure" plugin so it's pretty hard to test if you don't have.. well an insecure plugin. It's definitely working tough, but I see the HTML is still there. Like I said if you need a hand implementing it don't hesitate to let me know and I'll write it up.
Craig, do you know of a plugin/version that is insecure? I need one for testing.
(In reply to comment #7) > Craig, do you know of a plugin/version that is insecure? I need one for > testing. For testing I usually download an old version of Flash for Windows from http://www.oldversion.com
Yeah was just looking over screenshot a friend gave me. He was using Shockwave 10.0r32 so bring it up.
(In reply to comment #9) > Yeah was just looking over screenshot a friend gave me. He was using Shockwave > 10.0r32 so bring it up. It seems it's rather difficult to find and install an unsafe plugin. Any off the Adobe (Flash/Shockwave) plugins that have known vulnerabilities actually stop the installer and warn you to get a more recent version. Craig, if I remove that invalid HTML, would you be able to test the tooltips on our stage site?
Yeah no problem Steven, let me know when it's removed and I'll give it a test.
(In reply to comment #11) > Yeah no problem Steven, let me know when it's removed and I'll give it a test. Craig, can you test here: http://www-trunk.stage.mozilla.com/en-US/plugincheck/ Thanks.
Yep it's working fine :) Though needs to be styled a bit more me thinks!
(In reply to comment #13) > Yep it's working fine :) Though needs to be styled a bit more me thinks! Craig - it shouldn't look any different that the live site (http://www.mozilla.com/plugincheck). Does it? If so, do you mind posting a screenshot (sorry for the remote-debugging).
No problem, and yep looks identical :)
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Hey Steven, Can you verify that r81212 is the only revision from trunk to be pushed?
pushed to production r87306
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.