Closed Bug 624880 Opened 13 years ago Closed 13 years ago

JSD_GetScriptFunctionName should be renamed

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: igor, Assigned: igor)

References

Details

(Whiteboard: softblocker fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

ideally you'd fix the comments of the form " * Return name of function IFF JSDValue represents a function." to indicate 'new for gecko 2.0', but...
15.98 KB, patch
timeless
: review+
Details | Diff | Splinter Review
Summary: JSD_GetFunctionName should be renamed → JSD_GetScriptFunctionName should be renamed
Attached patch rename (obsolete) — — Splinter Review 
Timeless: If you do not have time, I will ask Brendan to review this renaming patch. And sorry for not asking you for the review of in the jsd parts of my patch.
Attachment #502965 - Flags: review?(timeless)
Comment on attachment 502965 [details] [diff] [review]
rename

http://hg.mozilla.org/mozilla-central/diff/e35b70ffed69/js/jsd/jsdebug.c lists 3 functions that need a rename

i'll delegate review to brendan for a patch which correctly renames the JSD_ exports. Note that the jsd_ functions can be renamed or not, that's up to you.
Attachment #502965 - Flags: review?(timeless) → review-
Whiteboard: softblocker
Does this need to be a softblocker?  Doesn't seem important.
(In reply to comment #3)
> Does this need to be a softblocker?  Doesn't seem important.

I don't know. The comments linked in comment 0 seem pretty insistent. Igor, what do you think?
This is a 10 minute patch and timeless is the module owner. Lets just do it.
from my perspective this is a hardblocker, someone broke an api. thou shalt not ship with it broken.

it indeed is a 10 minute job (or less).
Attachment #507851 - Attachment description: rename → ideally you'd fix the comments of the form " * Return name of function IFF JSDValue represents a function." to indicate 'new for gecko 2.0', but...
Attachment #507851 - Flags: review?(timeless) → review+
http://hg.mozilla.org/tracemonkey/rev/8835fffb27af
Whiteboard: softblocker → softblocker fixed-in-tracemonkey
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: