Closed
Bug 624880
Opened 14 years ago
Closed 14 years ago
JSD_GetScriptFunctionName should be renamed
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: igor, Assigned: igor)
References
Details
(Whiteboard: softblocker fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
Assignee | |
Updated•14 years ago
|
Summary: JSD_GetFunctionName should be renamed → JSD_GetScriptFunctionName should be renamed
|
|
Assignee | |
Comment 1•14 years ago
|
||
Timeless: If you do not have time, I will ask Brendan to review this renaming patch. And sorry for not asking you for the review of in the jsd parts of my patch.
Attachment #502965 -
Flags: review?(timeless)
Comment on attachment 502965 [details] [diff] [review]
rename
http://hg.mozilla.org/mozilla-central/diff/e35b70ffed69/js/jsd/jsdebug.c lists 3 functions that need a rename
i'll delegate review to brendan for a patch which correctly renames the JSD_ exports. Note that the jsd_ functions can be renamed or not, that's up to you.
Attachment #502965 -
Flags: review?(timeless) → review-
|
|
||
Updated•14 years ago
|
Whiteboard: softblocker
|
|
||
Comment 3•14 years ago
|
||
Does this need to be a softblocker? Doesn't seem important.
|
|
||
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Does this need to be a softblocker? Doesn't seem important.
I don't know. The comments linked in comment 0 seem pretty insistent. Igor, what do you think?
|
|
||
Comment 5•14 years ago
|
||
This is a 10 minute patch and timeless is the module owner. Lets just do it.
from my perspective this is a hardblocker, someone broke an api. thou shalt not ship with it broken.
it indeed is a 10 minute job (or less).
|
|
Assignee | |
Comment 7•14 years ago
|
||
This renames all affected functions.
Attachment #502965 -
Attachment is obsolete: true
Attachment #507851 -
Flags: review?(timeless)
Attachment #507851 -
Attachment description: rename → ideally you'd fix the comments of the form
" * Return name of function IFF JSDValue represents a function."
to indicate 'new for gecko 2.0', but...
Attachment #507851 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Comment 8•14 years ago
|
||
Whiteboard: softblocker → softblocker fixed-in-tracemonkey
|
|
||
Comment 9•14 years ago
|
||
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/8835fffb27af
|
|
||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
You need to log in
before you can comment on or make changes to this bug.
Description
•