624880 - JSD_GetScriptFunctionName should be renamed

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

See bug 612150 comment 9 -- bug 612150 comment 14

Comment 1

[Igor Bukanov]

Attachment: rename

Timeless: If you do not have time, I will ask Brendan to review this renaming patch. And sorry for not asking you for the review of in the jsd parts of my patch.

Comment 2

[timeless]

Comment on attachment 502965 [details] [diff] [review]
rename

http://hg.mozilla.org/mozilla-central/diff/e35b70ffed69/js/jsd/jsdebug.c lists 3 functions that need a rename

i'll delegate review to brendan for a patch which correctly renames the JSD_ exports. Note that the jsd_ functions can be renamed or not, that's up to you.

Comment 3

[Nicholas Nethercote [inactive]]

Does this need to be a softblocker?  Doesn't seem important.

Comment 4

[David Mandelin [:dmandelin]]

(In reply to comment #3)
> Does this need to be a softblocker?  Doesn't seem important.

I don't know. The comments linked in comment 0 seem pretty insistent. Igor, what do you think?

Comment 5

[Andreas Gal :gal]

This is a 10 minute patch and timeless is the module owner. Lets just do it.

Comment 6

[timeless]

from my perspective this is a hardblocker, someone broke an api. thou shalt not ship with it broken.

it indeed is a 10 minute job (or less).

Comment 7

[Igor Bukanov]

Attachment: ideally you'd fix the comments of the form " * Return name of function IFF JSDValue represents a function." to indicate 'new for gecko 2.0', but...

This renames all affected functions.

Comment 8

[Igor Bukanov]

http://hg.mozilla.org/tracemonkey/rev/8835fffb27af

Comment 9

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/8835fffb27af