624917 - undo close tab does not restore page with frameset

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Stefan]

User-Agent:       
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20101229 Firefox/4.0b9pre

http://www.irfanview.net/ is not restored properly if close is undone.

Reproducible: Always

Steps to Reproduce:
1. open http://www.irfanview.net/
2. close tab
3. undo close tab
Actual Results:  
MF displays empty page, only the browser's title is set.

Expected Results:  
Display page-content as it was when close tab was executed.

Comment 1

[Alice0775 White]

Confirmed on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110111 Firefox/4.0b10pre ID:20110111030357

Regression window(cached houry):
Works:
http://hg.mozilla.org/mozilla-central/rev/7fb1bd5802f0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100820
Minefield/4.0b5pre ID:20100820150311
Fails:
http://hg.mozilla.org/mozilla-central/rev/cbf6e0a17783
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100820
Minefield/4.0b5pre ID:20100820190548
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7fb1bd5802f0&tochange=cbf6e0a17783

Suspected:
cbf6e0a17783    Olli Pettay — Bug 588643 - Crash in [@
nsDocShell::SetHistoryEntry ], r=bent/neil, a=blocking

Comment 2

[Stefan]

A similar issue I have already reported in Bug 609396.

diff -r aafe919e786e docshell/shistory/src/nsSHEntry.cpp
--- a/docshell/shistory/src/nsSHEntry.cpp Sun Nov 07 13:59:51 2010 +0100
+++ b/docshell/shistory/src/nsSHEntry.cpp Sun Nov 07 14:40:01 2010 +0100
@@ -647,7 +647,7 @@
   // If aOffset is larger than Count(), we must first manually
   // set the capacity.
   if (aOffset > mChildren.Count()) {
-    mChildren.SetCount(aOffset);
+    // mChildren.SetCount(aOffset);
   }
   if (!mChildren.InsertObjectAt(aChild, aOffset)) {
     NS_WARNING("Adding a child failed!");

cures both of the issues.

Comment 3

[Johnny Stenback (:jst)]

Olli, looks like a regression from your changes. Can you have a look?

Comment 4

[Tony Chung [:tchung]]

Also reproduced on mac 64 builds.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110117 Firefox/4.0b10pre

Comment 5

[Stefan]

Fixed with fix of Bug 632835 (http://hg.mozilla.org/mozilla-central/rev/6229fab0d2e6)