624970 - expose DirectWrite version via GfxInfo

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[John Daggett (:jtd)]

Several dwrite bugs are related to the specific installed version of DirectWrite, so it's important to know the version in use when a user reports a problem.

Comment 1

[John Daggett (:jtd)]

Attachment: patch, add directwrite version to gfxinfo

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 503070 [details] [diff] [review]
patch, add directwrite version to gfxinfo

> direct2DEnabled = Direct2D Enabled
> directWriteEnabled = DirectWrite Enabled
>+dwriteVersion = DirectWrite Version

This is a string change, and we're string frozen. We should probably tell someone that we're adding this string.

>@@ -48,6 +48,7 @@ interface nsIGfxInfo : nsISupports
>    */
>   readonly attribute boolean D2DEnabled;
>   readonly attribute boolean DWriteEnabled;
>+  readonly attribute DOMString dwriteVersion;

This should be DWriteVersion to match DWriteEnabled.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #2)
> Comment on attachment 503070 [details] [diff] [review]
> This is a string change, and we're string frozen. We should probably tell
> someone that we're adding this string.

Can we just add the version after the enabled string:

DWrite Enabled: true/false, (version number)

Comment 4

[John Daggett (:jtd)]

Comment on attachment 503070 [details] [diff] [review]
patch, add directwrite version to gfxinfo

simple change needed for debugging dwrite io problems during startup

Comment 5

[John Daggett (:jtd)]

Attachment: patch v2b, add directwrite version to gfxinfo

Updated based on review comments.  Also added in OSX/Android stubs.

Comment 6

[Joe Drew (not getting mail)]

Comment on attachment 503744 [details] [diff] [review]
patch v2b, add directwrite version to gfxinfo

hip hip hooray!

Comment 7

[John Daggett (:jtd)]

Pushed to trunk
http://hg.mozilla.org/mozilla-central/rev/e632a03be51f

Comment 8

[John Daggett (:jtd)]

Attachment: patch, add version to list of gfx libraries on windows

Brian Birtles pointed out that the patch that landed messes up static library builds (i.e. rebuilding without linking XUL).  Adding 'version' to the list of windows libraries should solve this.

Comment 9

[Brian Birtles (:birtles)]

Confirming that attachment 504601 [details] [diff] [review] fixes the linker problem for me.

Comment 10

[[e-mail]]

Comment on attachment 504601 [details] [diff] [review]
patch, add version to list of gfx libraries on windows

I pushed this as a bustage fix because I had something else to push already.

http://hg.mozilla.org/mozilla-central/rev/2e8b3179b204