expose DirectWrite version via GfxInfo

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jtd, Assigned: jtd)

Tracking

Trunk
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

7 years ago
Several dwrite bugs are related to the specific installed version of DirectWrite, so it's important to know the version in use when a user reports a problem.
(Assignee)

Comment 1

7 years ago
Created attachment 503070 [details] [diff] [review]
patch, add directwrite version to gfxinfo
Attachment #503070 - Flags: review?(jmuizelaar)
Comment on attachment 503070 [details] [diff] [review]
patch, add directwrite version to gfxinfo

> direct2DEnabled = Direct2D Enabled
> directWriteEnabled = DirectWrite Enabled
>+dwriteVersion = DirectWrite Version

This is a string change, and we're string frozen. We should probably tell someone that we're adding this string.

>@@ -48,6 +48,7 @@ interface nsIGfxInfo : nsISupports
>    */
>   readonly attribute boolean D2DEnabled;
>   readonly attribute boolean DWriteEnabled;
>+  readonly attribute DOMString dwriteVersion;

This should be DWriteVersion to match DWriteEnabled.
Attachment #503070 - Flags: review?(jmuizelaar) → review+
(In reply to comment #2)
> Comment on attachment 503070 [details] [diff] [review]
> This is a string change, and we're string frozen. We should probably tell
> someone that we're adding this string.

Can we just add the version after the enabled string:

DWrite Enabled: true/false, (version number)
(Assignee)

Comment 4

7 years ago
Comment on attachment 503070 [details] [diff] [review]
patch, add directwrite version to gfxinfo

simple change needed for debugging dwrite io problems during startup
Attachment #503070 - Flags: approval2.0?
(Assignee)

Comment 5

7 years ago
Created attachment 503744 [details] [diff] [review]
patch v2b, add directwrite version to gfxinfo

Updated based on review comments.  Also added in OSX/Android stubs.
Attachment #503744 - Flags: review?(joe)
Attachment #503744 - Flags: approval2.0?
(Assignee)

Updated

7 years ago
Attachment #503744 - Attachment description: patch, add directwrite version to gfxinfo → patch v2b, add directwrite version to gfxinfo
Attachment #503070 - Flags: approval2.0?
Comment on attachment 503744 [details] [diff] [review]
patch v2b, add directwrite version to gfxinfo

hip hip hooray!
Attachment #503744 - Flags: review?(joe)
Attachment #503744 - Flags: review+
Attachment #503744 - Flags: approval2.0?
Attachment #503744 - Flags: approval2.0+
(Assignee)

Comment 7

7 years ago
Pushed to trunk
http://hg.mozilla.org/mozilla-central/rev/e632a03be51f
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

7 years ago
Created attachment 504601 [details] [diff] [review]
patch, add version to list of gfx libraries on windows

Brian Birtles pointed out that the patch that landed messes up static library builds (i.e. rebuilding without linking XUL).  Adding 'version' to the list of windows libraries should solve this.
Confirming that attachment 504601 [details] [diff] [review] fixes the linker problem for me.
Comment on attachment 504601 [details] [diff] [review]
patch, add version to list of gfx libraries on windows

I pushed this as a bustage fix because I had something else to push already.

http://hg.mozilla.org/mozilla-central/rev/2e8b3179b204
Attachment #504601 - Flags: review+
You need to log in before you can comment on or make changes to this bug.