Duplicated access key for search engines entry in update panel

VERIFIED FIXED in Firefox 8

Status

()

Firefox
Preferences
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: whimboo, Assigned: Javi Rueda)

Tracking

({access, verified-aurora, verified-beta})

Trunk
Firefox 8
access, verified-aurora, verified-beta
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa!])

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Created attachment 503124 [details]
screenshot

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20110109 Firefox/4.0b9pre ID:20110109030350

As our Mozmill l10n tests have been shown, the "Search Engines" entry in the advanced|update panel of the preferences dialog has a duplicated access key. See the screenshot. This has been introduced by bug 340677.
(Reporter)

Updated

7 years ago
Blocks: 630047
(Assignee)

Comment 1

6 years ago
Created attachment 549898 [details] [diff] [review]
Patch for bug 625018

Changes the access key from "h" to "e".
Attachment #549898 - Flags: review?(bzbarsky)
Comment on attachment 549898 [details] [diff] [review]
Patch for bug 625018

I'm probably the wrong reviewer for this.

Gavin, please redirect as needed?
Attachment #549898 - Flags: review?(bzbarsky) → review?(gavin.sharp)
Attachment #549898 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

6 years ago
I tend to look for the one that appears most time on the r=XXXX in the file log, Boris. Thanks for reviewing the patch, Gavin.

I am not the assignee of the bug (some day I will discover the way to do it), so I cannot change the status nor the keyword to "check-in needed".

Comment 4

6 years ago
I landed this on the fx-team branch, which will eventually be merged into mozilla-central.

http://hg.mozilla.org/integration/fx-team/rev/4ed43be4777c
Assignee: nobody → leofigueres
Whiteboard: [fixed-in-fx-team]
http://hg.mozilla.org/mozilla-central/rev/4ed43be4777c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8

Updated

6 years ago
Whiteboard: [qa+]

Comment 6

6 years ago
Setting resolution to Verified Fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:8.0) Gecko/20100101 Firefox/8.0
Mozilla/5.0 (Windows NT 6.1; rv:9.0a2) Gecko/20111002 Firefox/9.0a2
Mozilla/5.0 (Windows NT 6.1; rv:10.0a1) Gecko/20111002 Firefox/10.0a1

Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20100101 Firefox/8.0
Mozilla/5.0 (Windows NT 5.1; rv:9.0a2) Gecko/20111002 Firefox/9.0a2
Mozilla/5.0 (Windows NT 5.1; rv:10.0a1) Gecko/20111002 Firefox/10.0a1

Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0
Mozilla/5.0 (X11; Linux x86_64; rv:9.0a2) Gecko/20111002 Firefox/9.0a2
Mozilla/5.0 (X11; Linux x86_64; rv:10.0a1) Gecko/20110930 Firefox/10.0a1
Status: RESOLVED → VERIFIED
Keywords: verified-aurora, verified-beta
Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.