calling NPP_URLRedirectNotify with the original URL instead of the redirect target URL

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: [hardblocker])

Attachments

(1 attachment)

Assignee

Description

9 years ago
At least in the OOPP case I think we're passing the original request URL instead of the redirect target URL when we call NPP_URLRedirectNotify. This is wrong - we're supposed to be telling plugins where the stream is redirecting to.

Our automated tests on check for proper redirect handling results (the stream status and the URL for any written document) - they don't check the value of that parameter because the target URL is contrived and isn't factored into the decision to allow the redirect or not.

Mistake caught by Chromium developers. Thanks!
Assignee

Updated

9 years ago
blocking2.0: --- → betaN+

Updated

9 years ago
Whiteboard: [hardblocker]
Assignee

Comment 1

9 years ago
Posted patch fix v1.0Splinter Review
Assignee

Updated

9 years ago
Attachment #503407 - Flags: review?(dwitte)

Comment 2

9 years ago
Comment on attachment 503407 [details] [diff] [review]
fix v1.0

Who thought that one character could make all the difference?

r=dwitte!
Attachment #503407 - Flags: review?(dwitte) → review+
Assignee

Comment 3

9 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/ae9db11e316d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.