Closed Bug 625164 Opened 14 years ago Closed 14 years ago

calling NPP_URLRedirectNotify with the original URL instead of the redirect target URL

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(blocking2.0 betaN+)

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: jaas, Assigned: jaas)

Details

(Whiteboard: [hardblocker])

Attachments

(1 file)

At least in the OOPP case I think we're passing the original request URL instead of the redirect target URL when we call NPP_URLRedirectNotify. This is wrong - we're supposed to be telling plugins where the stream is redirecting to.

Our automated tests on check for proper redirect handling results (the stream status and the URL for any written document) - they don't check the value of that parameter because the target URL is contrived and isn't factored into the decision to allow the redirect or not.

Mistake caught by Chromium developers. Thanks!
blocking2.0: --- → betaN+
Whiteboard: [hardblocker]
Attached patch fix v1.0Splinter Review
Attachment #503407 - Flags: review?(dwitte)
Comment on attachment 503407 [details] [diff] [review]
fix v1.0

Who thought that one character could make all the difference?

r=dwitte!
Attachment #503407 - Flags: review?(dwitte) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/ae9db11e316d
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: