625249 - valgrind warnings in mozilla::FrameLayerBuilder::RemoveDisplayItemDataForFrame

Status: RESOLVED INVALID

(Core :: Web Painting, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: valgrind warnings

In an attempt to reproduce bug 623351, I did a clean build of http://hg.mozilla.org/mozilla-central/rev/f9537a28ce19 and uncommented the line "#define DEBUG_TRACEMALLOC_PRESARENA 1" in layout/base/nsPresArena.h (which most people running valgrind probably don't do, so they wouldn't see this).

While shutting down Firefox after a complete FBTest run (though I suspect much simpler steps would be sufficient), I got the attached warnings.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

These are still around, though the function is now called mozilla::FrameLayerBuilder::RemoveDisplayItemDataForFrame .

(If you want to test this *right now*, you'll need attachment 522165 [details] [diff] [review] from bug 645423.)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: first warning from non-optimized build

Actually, the difference is really in the optimization.  In an unoptimized build, running browser-chrome mochitests in toolkit/mozapps/extensions, the first warning is this.

Comment 3

[Gregory Pappas [:gregp]]

FrameLayerBuilder was removed in bug 1726291