625256 - Make the DOM timeout clamp a preference

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

This should be pretty easy to do, and would make it easier for nightly testers to experiment with different values, or for us to change the pref early in a release cycles and then backtrack later if issues arise.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make the DOM timeout clamp a pref, but enforce that it's nonnegative.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 503389 [details] [diff] [review]
Make the DOM timeout clamp a pref, but enforce that it's nonnegative.

>diff --git a/dom/base/nsGlobalWindow.cpp b/dom/base/nsGlobalWindow.cpp
>--- a/dom/base/nsGlobalWindow.cpp
>+++ b/dom/base/nsGlobalWindow.cpp
>@@ -265,18 +265,22 @@ PRInt32 gTimeoutCnt                     
> #if !(defined(NS_DEBUG) || defined(MOZ_ENABLE_JS_DUMP))
> static PRBool               gDOMWindowDumpEnabled      = PR_FALSE;
> #endif
> 
> #if defined(DEBUG_bryner) || defined(DEBUG_chb)
> #define DEBUG_PAGE_CACHE
> #endif
> 
>-// The shortest interval/timeout we permit
>-#define DOM_MIN_TIMEOUT_VALUE 6 // 6ms
>+// The default shortest interval/timeout we permit
>+#define DEFAULT_MIN_TIMEOUT_VALUE 10 // 10ms
>+static PRInt32 gMinTimeoutValue;
>+static inline PRInt32 DOMMinTimeoutValue() {
>+  return PR_MAX(gMinTimeoutValue, 0);

NS_MAX?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Er, yes.  Consider that fixed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Make the DOM timeout clamp a pref, but enforce that it's nonnegative.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/0fc37288b720

Comment 6

[Nickolay_Ponomarev]

The pref is "dom.min_timeout_value" (in ms) and it should be mentioned on https://developer.mozilla.org/en/DOM/window.setTimeout#Minimum_delay_and_timeout_nesting

Comment 7

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/DOM/window.setTimeout#Minimum_delay_and_timeout_nesting
https://developer.mozilla.org/en/Preferences/Mozilla_preferences_for_uber-geeks#DOM_preferences

And added a note to Firefox 4 for developers.