625385 - Add-on Bar changes its height when adding icons to it

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Sid]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110113 Firefox/4.0b10pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110113 Firefox/4.0b10pre

Add-on Bar changes its height when adding icons to it

Reproducible: Always

Steps to Reproduce:
1. Ensure Add-on Bar is enabled and empty. It's 20 px high (as planned in bug 598921).
2. Add any icon to Add-on Bar.
Actual Results:  
Add-on Bar gets 25 px high.

Expected Results:  
Add-on Bar should retain its height of 20 px.

Comment 1

[Sid]

Attachment: Empty Add-on Bar

Comment 2

[Sid]

Attachment: Add-on Bar with icon added

Comment 3

[Paul [pwd]]

That's the intended behaviour I believe.

Comment 4

[Dão Gottwald [:dao]]

Felipe, this is related to the excessive minimum height of toolbar buttons that I mentioned to you a while ago. We currently mitigate this with a negative margins, which is quite a hack (and not sufficient as this bug shows):
http://hg.mozilla.org/mozilla-central/annotate/b0fe7e0df71a/browser/themes/winstripe/browser/browser.css#l683

Linux has a similar problem and there we use negative margins on the icons, which is slightly less evil but doesn't seem to work on Windows:
http://hg.mozilla.org/mozilla-central/annotate/b0fe7e0df71a/browser/themes/gnomestripe/browser/browser.css#l1546
http://hg.mozilla.org/mozilla-central/annotate/b0fe7e0df71a/browser/themes/gnomestripe/browser/browser.css#l1597

Comment 5

[Sid]

I don't see it anymore since bug 631509 was fixed.

Comment 6

[Dão Gottwald [:dao]]

This has nothing to do with bug 631509.

Comment 7

[Siddhartha Dugar [:sdrocking]]

Attachment: Screenshot with Proxy Selector Button added

I use the Proxy Selector addon, and adding the proxy selector button to the add-on bar increases its height. Please fix this.
https://addons.mozilla.org/en-US/firefox/addon/proxy-selector/

Comment 8

[Ian Nartowicz]

This isn't fixed in beta 12.  I don't think this has ever been fixed.  The height of the addon bar changes when widgets are moved to it, and it changes massively when you opt for "text plus icons".

Comment 9

[Ed Morley [:emorley]]

Reopening per comment 8.

Ian, can you retest with the latest nightly and see if it still occurs - thanks.

Comment 10

[Ian Nartowicz]

Latest nightly, new profile, still happens.  The addon bar (initially just the close button and spacer) height increases slightly when a standard button is moved to it and increases dramatically if icons + text is selected.

Comment 11

[Corey Farwell]

Although this seems like a really nit-picky bug, it makes the addon-bar feel rather unpolished. If one addon widget is just slightly taller than another addon widget, it completely removes the aesthetics of both the toolbar and the browser as a whole. It's especially a nightmare to us addon devs who get constant complaints about our addon widgets not scaling vertically.

Comment 12

[:Gijs (he/him)]

The add-ons bar was removed, so closing this as WFM.