625418 - Youtube HTML5 video player broken again.

Status: RESOLVED DUPLICATE of bug 484396

(Core :: DOM: Core & HTML, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I could've sworn this was working just yesterday...


Video I'm using for testing is: http://www.youtube.com/watch?v=bM1epdLyhpA&html5=1

Works in Chrome 9 and Opera 11, but not in today's Minefield nightly.


Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXMLHttpRequest.open]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: http://s.ytimg.com/yt/jsbin/www-player-vfl7LJuym.js :: <TOP_LEVEL> :: line 47"  data: no]

Line 47 of that js file (prettified): http://pastebin.mozilla.org/936735

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Also broken in a Win64 build from last week.

I swear, I *just* was watching a WebM video on Youtube a few days ago...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm.  They're passing "" as the url to the open() method.

Jonas, why do we throw on empty urls instead of just resolving them relative to the base like any other url?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We seem to have thrown since the dawn of time. I doubt there is a good reason for it, we should just remove that line.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Not yet tested, but should work.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 503607 [details] [diff] [review]
Patch to fix

r=me

Comment 6

[Johnny Stenback (:jst)]

Do we know if open("") ends up loading the current baseURI in other browsers as well, or is it a noop in other browsers? I think we should take a fix for this, but I'd like to know what other browsers do here.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fwiw, the spec doesn't say to do anything special here. But yes, might be worth testing in other browsers.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Based on the patch this is a dup of Bug 484396.