625437 - Use 'Importance' / 'X-Priority' headers in incoming mail to influence bug's initial priority

Status: RESOLVED FIXED

(Bugzilla :: Incoming Email, enhancement)

Description

[Reed Loden [:reed]]

email_in.pl should check incoming e-mails for 'Importance' (and/or 'X-Priority') header(s). If it/they is/are present, use the value of the 'Importance' header to influence the initial priority of the bug. I've seen at least one other bug tracker do this well, and it's very useful if you're mostly only submitting bugs via e-mail.

For example, if an e-mail has 'Importance: High', the bug should be set to P1. If it's 'Importance: Low', set it to P5. X-Priority field may also influence this somewhat.

http://tools.ietf.org/html/rfc4021#section-2.1.52

Comment 1

[Max Kanat-Alexander]

Sounds reasonable. I think a good implementation would be something like this:

1) If somebody specifies @priority, use it.
2) If there's an importance header, use it as something that is relative to the default priority. So if it's High, increase the priority by 1. If it's Low, decrease the priority by 1.
3) Otherwise, use the default priority.

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1 (untested)

First crack at this... Untested.

Comment 3

[Reed Loden [:reed]]

Comment on attachment 503615 [details] [diff] [review]
patch - v1 (untested)

I can't really test this, as I have no dev environment that supports the incoming e-mail stuff.

Comment 4

[Frédéric Buclin]

Do we want to also look at X-Priority, as Thunderbird doesn't support Importance yet (bug 406189)?

Comment 5

[Frédéric Buclin]

Comment on attachment 503615 [details] [diff] [review]
patch - v1 (untested)

>+    my $importance = $input_email->header('Importance');

Please also look at the X-Priority header, as Thunderbird doesn't set nor understand the Importance header, see my previous comment:

  my $importance = $input_email->header('Importance') || $input_email->header('X-Priority')


>+        my $legal_priorities = Bugzilla::Field::get_legal_field_values('priority');

get_legal_field_values() is exported by Bugzilla::Field, so you don't need to prepend Bugzilla::Field:: when calling the method.


>+        my $i = firstidx { $_ eq Bugzilla->params->{'defaultpriority'} } @legal_priorities;

Your code doesn't compile because you defined $legal_priorities (arrayref) and here and below you use @legal_priorities (array):

   "Global symbol "@legal_priorities" requires explicit package name at ./email_in.pl line 156."


>+        if ($importance =~ /high/i) {
>+            $i++ unless $i == $#legal_priorities;
>+        }

You did it the wrong way. A higher priority has a lower index, and vice versa.

Comment 6

[Reed Loden [:reed]]

Attachment: patch - v2 (untested)

Comment 7

[Reed Loden [:reed]]

Attachment: patch - v3 (untested)

Oops, had a typo in the last one... Also, removed X-MSMail-Priority, as per IRC discussion.

Comment 8

[Frédéric Buclin]

Comment on attachment 647713 [details] [diff] [review]
patch - v3 (untested)

Please test your patch! It doesn't compile:

Global symbol "@legal_priorities" requires explicit package name at ./email_in.pl line 163.
Global symbol "@legal_priorities" requires explicit package name at ./email_in.pl line 165.
Execution of ./email_in.pl aborted due to compilation errors.


You don't need any special environment to test your patch. Just save an email (with its headers) in a text file, and call: ./email_in.pl < email.txt

Comment 9

[Reed Loden [:reed]]

Attachment: patch - v4 (untested)

compiles now. ;)

Comment 10

[Reed Loden [:reed]]

Attachment: patch - v5 (untested)

This should only be used for new bugs.

Comment 11

[Frédéric Buclin]

Comment on attachment 647748 [details] [diff] [review]
patch - v5 (untested)

>+    # The importance/priority field is only used for a post_bug.

"The Importance/X-Priority field is only used when creating a new bug".


>+    # 2) If there's an importance header, use it as something that

"If there is an Importance or X-Priority header, ..."


r=LpSolit

Comment 12

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified email_in.pl
Committed revision 8320.

Comment 13

[Frédéric Buclin]

Added to relnotes for 4.4.