625438 - JM: watch handler is not always called

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Testcase:
--
var count = 0;
watch("x", function() {
    count++;
});
for(var i=0; i<10; i++) {
    x = 2;
}
print(count);
--
Output:

-m: 1
-j: 10
interp: 10

Comment 1

[Jan de Mooij [:jandem]]

Btw adding a print('test'); statement inside the handler makes it print 2 instead of 1.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Method JIT is testing getterness instead of setterness in SetGlobalName().

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 503558 [details] [diff] [review]
fix

Yecch, that's a gross bug. Looks like exactly the right fix.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/tracemonkey/rev/96f460867847

Comment 5

[Jan de Mooij [:jandem]]

http://hg.mozilla.org/mozilla-central/rev/96f460867847