When I rename a bookmark in the personal bar from "foo bar" to "bar" by double-clicking "foo" and then pressing the Del keystroke, and then saving the change, the change is not effective. But if I click right before "bar", then hit the backspace keystroke several times to delete "foo", then it works. Tested with 4.0 beta9. Aleksej can reproduce with yesterday's nightly.
Summary of comment 0: if the only action is to delete something from the bookmark's name using Del, it has no effect.
Regression window: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d1da1005b6d6&tochange=4f03895d544b
Requesting blocking as it's a regression between beta 8 and beta 9.
--> Core::Editor, strongly suspect Ehsan's patch for bug 527935. If that's the case, can someone please mention that over in that bug before we take it on branches and break those, too!
Can you reproduce this on trunk? I couldn't on a mozilla-central nightly on Mac.
I managed to reproduce this using the Cut command instead of pressing Del.
(In reply to comment #7) > I managed to reproduce this using the Cut command instead of pressing Del. Looks like it's Cut on Mac and Del on Linux (I was testing on Linux).
Yes, I've determined the cause. The fix is easy, and I'll post a patch soon.
Created attachment 504204 [details] [diff] [review] Patch (v1)
Comment on attachment 504204 [details] [diff] [review] Patch (v1) The regressing bug 527935 has not yet landed on old branches, and in that bug ehsan said none of the patches applied without merge work. Clearing the branch approval requests, but please re-request if this one was correct. (but a roll-up patch in bug 527935 is probably better.)
Verified fixed with Firefox 4b11build3.