Closed Bug 625452 Opened 14 years ago Closed 14 years ago

Cannot rename a bookmark by using the "Del" keystroke

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b10
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: LpSolit, Assigned: ehsan.akhgari)

References

Details

(Keywords: regression, Whiteboard: [softblocker][fx4-fixed-bugday])

Attachments

(1 file)

Patch (v1)
9.21 KB, patch
roc
: review+
Details | Diff | Splinter Review 
When I rename a bookmark in the personal bar from "foo bar" to "bar" by double-clicking "foo" and then pressing the Del keystroke, and then saving the change, the change is not effective. But if I click right before "bar", then hit the backspace keystroke several times to delete "foo", then it works.

Tested with 4.0 beta9. Aleksej can reproduce with yesterday's nightly.
Summary of comment 0: if the only action is to delete something from the bookmark's name using Del, it has no effect.
Requesting blocking as it's a regression between beta 8 and beta 9.
blocking2.0: --- → ?
--> Core::Editor, strongly suspect Ehsan's patch for bug 527935. If that's the case, can someone please mention that over in that bug before we take it on branches and break those, too!
Component: Bookmarks & History → Editor
Product: Firefox → Core
QA Contact: bookmarks → editor
Assignee: nobody → ehsan
blocking2.0: ? → final+
Whiteboard: [softblocker]
Can you reproduce this on trunk?  I couldn't on a mozilla-central nightly on Mac.
I managed to reproduce this using the Cut command instead of pressing Del.
(In reply to comment #7)
> I managed to reproduce this using the Cut command instead of pressing Del.

Looks like it's Cut on Mac and Del on Linux (I was testing on Linux).
Yes, I've determined the cause.  The fix is easy, and I'll post a patch soon.
Blocks: CVE-2011-0067
Attached patch Patch (v1) — — Splinter Review 

        Attachment #504204 -
        Flags: review?(roc)

    
  
Whiteboard: [softblocker] → [softblocker][has patch][needs review roc]

    
  
Whiteboard: [softblocker][has patch][needs review roc] → [softblocker][needs landing]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/9698210ea3c6
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [softblocker][needs landing] → [softblocker]
Target Milestone: --- → mozilla2.0b10

    
  

        Attachment #504204 -
        Flags: approval1.9.2.15?

        Attachment #504204 -
        Flags: approval1.9.1.18?

    
    

    
  
Comment on attachment 504204 [details] [diff] [review]
Patch (v1)

The regressing bug 527935 has not yet landed on old branches, and in that bug ehsan said none of the patches applied without merge work. Clearing the branch approval requests, but please re-request if this one was correct. (but a roll-up patch in bug 527935 is probably better.)

        Attachment #504204 -
        Flags: approval1.9.2.15?

        Attachment #504204 -
        Flags: approval1.9.1.18?

    
    

    
  
Verified fixed with Firefox 4b11build3.
Status: RESOLVED → VERIFIED
Whiteboard: [softblocker] → [softblocker][fx4-fixed-bugday]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: