625478 - First paint timestamp is broken on OSX and Android

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Dave Townsend [:mossop]]

Bug 522375 attempts to report when the first paint happened but it doesn't work on OSX or Android.

Comment 1

[Timothy Nikkel (:tnikkel)]

I think this is because the first paint time is captured in the view manager for an NS_DID_PAINT event. We don't send NS_DID_PAINT events in all platforms.

Comment 2

[Timothy Nikkel (:tnikkel)]

Taras, see comment 1.

Comment 3

[(dormant account)]

(In reply to comment #1)
> I think this is because the first paint time is captured in the view manager
> for an NS_DID_PAINT event. We don't send NS_DID_PAINT events in all platforms.

Is there a better place to hook into?

Comment 4

[Timothy Nikkel (:tnikkel)]

I think in nsViewManager::RenderViews after the mObserver->Paint call should be a good place.

Comment 5

[(dormant account)]

Attachment: better firstpaint hook

Comment 6

[Timothy Nikkel (:tnikkel)]

Comment on attachment 503647 [details] [diff] [review]
better firstpaint hook

>@@ -447,6 +447,8 @@ void nsViewManager::RenderViews(nsView *
>     mObserver->Paint(displayRoot, aView, aWidget, region, aIntRegion,
>                      aPaintDefaultBackground, aWillSendDidPaint);
>   }
>+  if (!gFirstPaintTimestamp)
>+    gFirstPaintTimestamp = PR_Now();
> }

Nit: you might want to put this inside the "if (mObserver)" block, if we don't call Paint then we aren't painting anything at all. r+ with that change.

Comment 7

[(dormant account)]

Attachment: better firstpaint hook

Comment 8

[(dormant account)]

http://hg.mozilla.org/mozilla-central/rev/fc57718d8a48