Closed
Bug 625503
Opened 15 years ago
Closed 15 years ago
convert NaN correctly with typed array array conversion
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: vlad, Assigned: vlad)
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
Waldo
:
review+
dvander
:
approval2.0+
|
Details | Diff | Splinter Review |
currently, new Int32Array([NaN])[0] != 0 like it should be, because the code that creates a new typed array from an existing array isn't handling NaN values correctly. The attached patch fixes that.
Attachment #503632 -
Flags: review?(jwalden+bmo)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 503632 [details] [diff] [review]
typedarray nan conversion fix
Those casts have undefined behavior in C/C++, right? So currently you have no idea what you'll get there, right? Doesn't really matter, just curious and suspect you already looked at a spec, whereas I'd have to make an effort to look. ;-)
Attachment #503632 -
Flags: review?(jwalden+bmo) → review+
|
Assignee | |
Comment 2•15 years ago
|
||
Comment on attachment 503632 [details] [diff] [review]
typedarray nan conversion fix
asking for a2.0 -- typed array bug, and affects a webgl test that checks typed arrays.
Attachment #503632 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #503632 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•