625629 - Don't define MMX define in SSE.h since Microsoft compiler for x64 doesn't support MMX

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Makoto Kato [:m_kato]]

http://msdn.microsoft.com/ja-jp/library/698bxz2w.aspx

"MMX intrinsics use the __m64 data type, which is not supported on x64 processors. "

Comment 1

[Makoto Kato [:m_kato]]

Also, bustage by bug 

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1294920732.1294924843.19536.gz#err0

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 503739 [details] [diff] [review]
fix

canel. I will refresh this.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: fix v2

Comment 5

[Justin Lebar (not reading bugmail)]

Comment on attachment 503789 [details] [diff] [review]
fix v2

Just a few nits on the comments:

>+# Microsoft Compiler doesn't support MMX
>+ifdef _MSC_VER
>+ifneq ($(OS_TEST),x86_64)
>+CPPSRCS += yuv_convert_mmx.cpp
>+endif

Suggest

> # MSVC doesn't support MMX when targeting AMD64.

> #if defined(_M_AMD64)
>-  // MMX is always available on AMD64.
>-  #define MOZILLA_PRESUME_MMX
>+  // Don't define MMX on Microsoft Visual C++ x64.
>+  // Microsoft Visual C++ doesn't support MMX although OS supports it

Suggest

> // MSVC for AMD64 doesn't support MMX, so don't presume it here.

>+#if !(defined(_MSC_VER) && defined(_M_AMD64))
>+  // Don't define MMX since compiler doesn't support it .
> #define MOZILLA_MAY_SUPPORT_MMX 1
>+#endif

Suggest

> // Define MOZILLA_MAY_SUPPORT_MMX only if we're not on MSVC for 
> // AMD64, since that compiler doesn't support MMX.

r=me with those changes.

Comment 6

[Makoto Kato [:m_kato]]

Attachment: for checkin

Comment 7

[Makoto Kato [:m_kato]]

Comment on attachment 504403 [details] [diff] [review]
for checkin

Although this is bustage fix for Win64 build, do I need approval 2.0?

Comment 8

[Justin Lebar (not reading bugmail)]

(In reply to comment 7)

khuey says no.  Go for it.

Comment 9

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/mozilla-central/rev/36bee2169e32