"Assertion failure: !cx->isExceptionPending()" with setUserData, getter

RESOLVED FIXED in mozilla10

Status

()

Core
XPConnect
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: sfink)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla10
x86
Mac OS X
assertion, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 503720 [details]
testcase

Assertion failure: !cx->isExceptionPending(), at js/src/jscntxtinlines.h:695

The stack trace for the assertion is very long, but an opt build does not crash.
(Reporter)

Comment 1

6 years ago
Created attachment 503721 [details]
stack trace
(Reporter)

Comment 2

6 years ago
Oh, I bet this is a bug involving JS_CHECK_RECURSION recovery.
(Reporter)

Comment 3

6 years ago
I think this bug is making it difficult to create reduced testcases for other JS_CHECK_RECURSION bugs, some of which may be more serious.
(Assignee)

Comment 4

6 years ago
Created attachment 569174 [details] [diff] [review]
Fix XPCConvert error handling

I don't know this code either, but the test case and assert seemed nice and straightforward so I took a quick look. The debugger pointed to code that seemed highly suspicious. This patch fixes the attached test case and seems better, at least, than what's there now. I may get lazy and mark this as checkin-needed, though.

The problem seems to be that there are at least half a dozen ways for XPCConvert::NativeInterface2JSObject to return false without setting the nsresult to an error value, because it gets whitewashed prematurely.
Attachment #569174 - Flags: review?(mrbkap)
Comment on attachment 569174 [details] [diff] [review]
Fix XPCConvert error handling

Yep, my bad. Thanks for catching this.
Attachment #569174 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec39a58d7f39
Assignee: nobody → sphink
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/ec39a58d7f39
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.