625893 - The word "English" should be translatable

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P2)

Description

[Underpass]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.2.13) Gecko/20101203 Debian Firefox/3.6.13
Build Identifier: 

In strings like 

"Stop getting emailed when {locale} revisions are approved"

the word {locale} becomes "English", and so when the sentence is translated, it will contains this foreign word (for non-English-speaking people) only.

Could it be possible to substitute {locale} with plain 'English'?

Reproducible: Always

Comment 1

[James Socol [:jsocol, :james]]

Sure.

Comment 2

[James Socol [:jsocol, :james]]

OK, so one hitch: we use the same string for English and non-English locales, and just format in the locale name.

I'm fixing this by creating two identical strings with different contexts and comments. With the 'english' context, you'll need to localize the word "English," with the 'locale' context, you'll need to replace "English" with whatever language.

Comment 3

[James Socol [:jsocol, :james]]

https://github.com/jsocol/kitsune/commit/e302c1cfd4

Comment 4

[Rebecca Billings [:rbillings]]

I looked at the checkin and am wondering if this is visible for testing on the frontend?

Comment 5

[Rebecca Billings [:rbillings]]

Closing this as fixed based on the checkin, ultimately it will be verified by a translator. Please re-open if this issue persists.