Android content process crash if crash reporter is disabled

RESOLVED FIXED in mozilla7

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

Trunk
mozilla7
All
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 504025 [details] [diff] [review]
fix non-crashreporter builds

Building with --disable-crashreporter results in a content process crash at startup.  A variable in linker.cpp was only being initialized in #ifdef MOZ_CRASHREPORTER, but was used outside of it.  Added some defensive code at the usage point as well.
Attachment #504025 - Flags: review?(mwu)

Updated

6 years ago
Attachment #504025 - Flags: review?(mwu) → review+
Attachment #504025 - Flags: approval2.0?
Attachment #504025 - Flags: approval2.0? → approval2.0+
Comment on attachment 504025 [details] [diff] [review]
fix non-crashreporter builds

Sorry, it's too late for 2.0.
Attachment #504025 - Flags: approval2.0+ → approval2.0-

Comment 2

6 years ago
Applies cleanly to m-c tip, presume this is still wanted / can be set to checkin-needed?
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/810dee34da1f
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
Merged in mozilla-central, backed out and re-pushed with a bug number:
http://hg.mozilla.org/mozilla-central/rev/e237b7b684ac
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.