Closed
Bug 625951
Opened 15 years ago
Closed 15 years ago
Android content process crash if crash reporter is disabled
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla7
People
(Reporter: vlad, Assigned: vlad)
Details
Attachments
(1 file)
|
1.48 KB,
patch
|
mwu
:
review+
joe
:
approval2.0-
|
Details | Diff | Splinter Review |
Building with --disable-crashreporter results in a content process crash at startup. A variable in linker.cpp was only being initialized in #ifdef MOZ_CRASHREPORTER, but was used outside of it. Added some defensive code at the usage point as well.
Attachment #504025 -
Flags: review?(mwu)
Updated•15 years ago
|
Attachment #504025 -
Flags: review?(mwu) → review+
| Assignee | ||
Updated•15 years ago
|
Attachment #504025 -
Flags: approval2.0?
Updated•15 years ago
|
Attachment #504025 -
Flags: approval2.0? → approval2.0+
Comment 1•15 years ago
|
||
Comment on attachment 504025 [details] [diff] [review]
fix non-crashreporter builds
Sorry, it's too late for 2.0.
Attachment #504025 -
Flags: approval2.0+ → approval2.0-
Comment 2•15 years ago
|
||
Applies cleanly to m-c tip, presume this is still wanted / can be set to checkin-needed?
Updated•15 years ago
|
Keywords: checkin-needed
Comment 3•15 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
Comment 4•15 years ago
|
||
Merged in mozilla-central, backed out and re-pushed with a bug number:
http://hg.mozilla.org/mozilla-central/rev/e237b7b684ac
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Version: unspecified → Trunk
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•