Last Comment Bug 625951 - Android content process crash if crash reporter is disabled
: Android content process crash if crash reporter is disabled
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All Android
-- normal (vote)
: mozilla7
Assigned To: Vladimir Vukicevic [:vlad] [:vladv]
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
  Show dependency treegraph
Reported: 2011-01-14 16:08 PST by Vladimir Vukicevic [:vlad] [:vladv]
Modified: 2011-05-25 23:54 PDT (History)
3 users (show)
bzbarsky: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix non-crashreporter builds (1.48 KB, patch)
2011-01-14 16:08 PST, Vladimir Vukicevic [:vlad] [:vladv]
mwu.code: review+
joe: approval2.0-
Details | Diff | Splinter Review

Description User image Vladimir Vukicevic [:vlad] [:vladv] 2011-01-14 16:08:39 PST
Created attachment 504025 [details] [diff] [review]
fix non-crashreporter builds

Building with --disable-crashreporter results in a content process crash at startup.  A variable in linker.cpp was only being initialized in #ifdef MOZ_CRASHREPORTER, but was used outside of it.  Added some defensive code at the usage point as well.
Comment 1 User image Joe Drew (not getting mail) 2011-03-03 10:10:08 PST
Comment on attachment 504025 [details] [diff] [review]
fix non-crashreporter builds

Sorry, it's too late for 2.0.
Comment 2 User image Ed Morley [:emorley] 2011-05-25 05:21:13 PDT
Applies cleanly to m-c tip, presume this is still wanted / can be set to checkin-needed?
Comment 3 User image Boris Zbarsky [:bz] (still a bit busy) 2011-05-25 19:20:06 PDT
Comment 4 User image Mounir Lamouri (:mounir) 2011-05-25 23:54:04 PDT
Merged in mozilla-central, backed out and re-pushed with a bug number:

Note You need to log in before you can comment on or make changes to this bug.