625956 - Replace both drop marker and bookmark star on URL preview hover

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Alex Limi (:limi) — Firefox UX Team]

After the introduction of the new, more subtle bookmark star, the transition from hovering over 

Current behaviors, * is bookmark star, ▼ is pulldown:

No URL preview:

  http://example.com         * ▼ 

With URL preview active:

  http://example.com  > http://example.net ▼

Proposed behavior, both glyphs are taken out by the hover:

  http://example.com  > http://example.net


The pulldown marker has no function when you're hovering over a link, and should be removed. We have tested this with Margaret's current patch, and it doesn't feel any more disruptive than the current behavior when the pulldown marker is moved into the area that is affected by the transition.

Comment 1

[:Margaret Leibovic]

Attachment: patch

Moving the dropmarker inside the .urlbar-textbox-container-children element lets it pick up the styles to fade in/out appropriately. This doesn't seem to break the dropmarker's functionality, but I may be unaware of reasons why the element is where it currently is.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 504030 [details] [diff] [review]
patch

I don't understand why you're inheriting overlinkstate.

Comment 3

[:Margaret Leibovic]

(In reply to comment #2)
> Comment on attachment 504030 [details] [diff] [review]
> patch
> 
> I don't understand why you're inheriting overlinkstate.

Oops, I left that in there from an earlier iteration of the patch. I should get rid of that.

Comment 5

[Drew Willcoxon :adw]

IIRC the reason I didn't make the preview cover up the dropdown arrow was because in RTL locales (on non-OS X platforms), the dropdown appears at the left side of the location bar.  I don't have my Windows box handy so I can't test this patch, but I think it might break that RTL behavior.  My guess is that we'd have to special-case LTR locales if we want the preview to cover the arrow. :(

Comment 6

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #5)
> IIRC the reason I didn't make the preview cover up the dropdown arrow was
> because in RTL locales (on non-OS X platforms), the dropdown appears at the
> left side of the location bar.

It shows up on the right side here in RTL mode, is the behavior different on Windows?

> I don't have my Windows box handy so I can't
> test this patch, but I think it might break that RTL behavior.  My guess is
> that we'd have to special-case LTR locales if we want the preview to cover the
> arrow. :(

A related bug is probably bug 610682, which is currently a hard blocker.

CCing Ehsan & Mano for input.

Comment 7

[Drew Willcoxon :adw]

(In reply to comment #6)
> It shows up on the right side here in RTL mode, is the behavior different on
> Windows?

Yes, that's why I said non-OS X platforms.  I don't know why that's the case.

Comment 8

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #7)
> (In reply to comment #6)
> > It shows up on the right side here in RTL mode, is the behavior different on
> > Windows?
> 
> Yes, that's why I said non-OS X platforms.  I don't know why that's the case.

Great, just double checking that I understood it correctly. :)

Hopefully bug 610682 can/will make this more consistent, but I'll wait for input from Ehsan or Mano, since my RTL experience is limited.

Comment 9

[(no longer active)]

Seems like the two icons are going to be moved to the left side of the location bar in RTL mode for all platforms.  I'd rather hold this bug until bug 610682 lands to make sure that we're relying on the correct placement here.

Comment 10

[(no longer active)]

(In reply to comment #9)
> Seems like the two icons are going to be moved to the left side of the location
> bar in RTL mode for all platforms.  I'd rather hold this bug until bug 610682
> lands to make sure that we're relying on the correct placement here.

That's actually the direction that we're going to take.  Margaret, if you keep the latest patch from that bug applied in your queue, I think you can continue your work here assuming that patch has landed.

Comment 11

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #10)
> That's actually the direction that we're going to take.  Margaret, if you keep
> the latest patch from that bug applied in your queue, I think you can continue
> your work here assuming that patch has landed.

Thanks, Ehsan!

Comment 12

[:Margaret Leibovic]

Marking this bug as INVALID, since we're not doing URL preview hover in the location bar anymore.