625985 - [regression] Panning gestures during kinetic panning are ignored

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Open a tall page.
2. Flick to scroll down.
3. While the page is still scrolling, flick again and again.

Expected results: Each flick adds to the scrolling momentum and causes the page to pan faster and longer.

Actual results: Flicks while the page is scrolling are ignored, until the scrolling has completely stopped.

Possible regression from bug 618249 or bug 605618?

Comment 1

[Benjamin Stover (:stechz)]

Attachment: Panning gestures during kinetic panning are ignored

Comment 2

[Benjamin Stover (:stechz)]

I'm not sure why this wasn't a problem before (maybe due to a change in MozBeforePaint in the platform?), but we were disregarding deltas that were waiting for a paint. Testing it on mobile to make sure kinetic panning feels right.

Comment 3

[Benjamin Stover (:stechz)]

Attachment: Panning gestures during kinetic panning are ignored

Comment 4

[Benjamin Stover (:stechz)]

Comment on attachment 504796 [details] [diff] [review]
Panning gestures during kinetic panning are ignored

This is a little more sophisticated. I've factored out _doDragMove because I felt its purpose was ill defined and we now only call it in one place.

This patch continues to feed kinetic panning the mouse events it craves on time while keeping the dragger object limited to one call per paint.

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 504796 [details] [diff] [review]
Panning gestures during kinetic panning are ignored

>   /**
>+   * Used by _onMouseMove() above and by KineticController's timer to do the
>    * actual dragMove signalling to the dragger.  We'd put this in _doDragMove()
>    * but then KineticController would be adding to its own data as it signals
>    * the dragger of dragMove()s.
>    */

Remove the reference to _doDragMove(), which doesn't exist any more.

Comment 6

[Benjamin Stover (:stechz)]

http://hg.mozilla.org/mobile-browser/rev/cbd1a57e978b

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified: Mozilla/5.0 (Android; Linux armv71; rv2.0b10pre) Gecko/20110119 Firefox/4.0b10pre Fennec/4.0b4pre

Comment 8

[Andreea Pod]

Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110513 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)