626087 - Error when syncing passwords

Status: RESOLVED DUPLICATE of bug 621846

(Firefox :: Sync, defect)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I copied in my sync key from another computer's "show passwords", and it's working, but when it got to the upload stage of my passwords from the local machine it barfed in its mouth a little:

2011-01-15 12:46:10     Engine.Passwords     INFO       5 outgoing items pre-reconciliation
2011-01-15 12:46:11     Store.Passwords      DEBUG      Adding login for https://www.cloudkick.com
2011-01-15 12:46:11     Collection           WARN       Got exception calling onProgress handler during fetch of https://phx-sync087.services.mozilla.com/1.0/shaver/storage/passwords?full=1
2011-01-15 12:46:11     Collection           DEBUG      'specified GUID already
exists' when calling method: [nsILoginManagerStorage::addLogin] Stack trace: resource://gre/components/nsLoginManager.js:411 < PasswordStore__create()@resource://services-sync/engines/passwords.js:192 < Store_applyIncoming()@resource://services-sync/stores.js:66 < resource://services-sync/engines.js:481 < innerBind()@resource://services-sync/util.js:1398 < resource://services-sync/base_records/collection.js:154 < Channel_onDataAvail()@resource://services-sync/resource.js:464
2011-01-15 12:46:11     Engine.Passwords     DEBUG      Total (ms): sync 1117, processIncoming 743, syncStartup 374, findDupe 4, reconcile 9, syncCleanup 0
2011-01-15 12:46:11     Service.Main         DEBUG      passwords failed: NS_ERROR_XPC_JS_THREW_STRING JS Stack trace: Res_get()@resource.js:376 < SyncEngine__processIncoming()@engines.js:499 < ()@engines.js:203 < SyncEngine__sync()@engines.js:756 < ()@engines.js:203 < WrappedNotify()@util.js:158 < Engine_sync()@engines.js:213 < WeaveSvc__syncEngine([object Object])@service.js:1868 < ()@service.js:1754 < WrappedNotify()@util.js:158 < WrappedLock()@util.js:126 < _lockedSync()@service.js:1659 < ()@service.js:1650 < WrappedCatch()@util.js:100 < sync()@service.js:1631 < (15)@browser.js:5213

It also put up the error status bar at the bottom, which is why I'm filing.

Using the 1/15 build on Windows.  GUID duplication probably a result of having had sync set up once before it fell off during the Great Key Revolution.

Comment 1

[Philipp von Weitershausen [:philikon]]

This looks a lot like bug 621846. Do you also see "Couldn't decrypt string" in the error console like Henrik?

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Nothing in the error console for me.

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

(I don't think it's having trouble decrypting, because it can see the GUID, but maybe the GUID isn't encrypted!)

Comment 4

[Philipp von Weitershausen [:philikon]]

The "Couldn't decrypt string" error msg may or may not be a red herring in Henrik's bug. He's definitely seeing the same exception in about:sync-log as you ('specified GUID already exists'). And yes, the GUID isn't encrypted. But Henrik's "Couldn't decrypt string" isn't Sync's error, it's the Password Manager's.

The mystery really is why Sync would try to *add* a record whose GUID already exists instead of modifying it. Sounds like writing some unit tests for this is in order.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

This looks similar to bug 621846 and is old, so I'm assuming it is the same. I've also got a STR.