626138 - Bug 616841 has broken non-libxul builds when trying to build xpcshell, with undefined symbol "xpc_LocalizeContext(JSContext*)"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

ehsanakhgari:~/moz/mozilla-central/obj-ff-dbg/js/src/xpconnect/shell [05:30:30]$ make
make export
make[1]: Nothing to be done for `export'.
make libs
g++-4.2 -o xpcshell  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -fno-strict-aliasing -fpascal-strings -fno-common -fshort-wchar -pthread -DNO_X11 -pipe  -DDEBUG -D_DEBUG -DTRACING -g  xpcshell.o xpcshellMacUtils.o   -framework Cocoa -lobjc  -framework ExceptionHandling -Wl,-executable_path,/Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dist/bin -L../../../../dist/bin -L../../../../dist/lib ../../../../dist/lib/libxpcomglue_s.a -L/Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dist/bin -lxpcom -lmozalloc /Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dist/bin/XUL -L/Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dist/bin -lxpcom -lxpcom_core -lmozalloc  -L/Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dist/bin -lmozjs -L/Users/ehsanakhgari/moz/mozilla-central/obj-ff-dbg/dist/lib -lplds4 -lplc4 -lnspr4     
Undefined symbols:
  "xpc_LocalizeContext(JSContext*)", referenced from:
      _main in xpcshell.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[1]: *** [xpcshell] Error 1
make: *** [default] Error 2



I tried hacking around the breakage, but couldn't.  Chris can probably come up with a real fix, so I'm assigning this to him.

Comment 1

[Boris Zbarsky [:bzbarsky]]

In the short run, can we just not make this call in xpcshell in the non-libxul builds?  That will make the test for bug 616841 fail, but this isn't exactly a supported configuration anyway, right?

Comment 2

[[e-mail]]

(In reply to comment #0)
> I tried hacking around the breakage, but couldn't.
That would be tricky; xpcshell uses the external API, so it obviously can't link to any static libs. And in a non-libxul build the symbol can't be resolved because gklayout is a component and therefore lives in the wrong folder. There are still at least three potential options though:
1. Like bz says, just #ifdef the call in non-libxul builds
2. Make the call live on some interface somewhere
3. Make xpcshell compile with both internal or external API appropriately

Comment 3

[(no longer active)]

Attachment: Patch (v1)

Don't call the function on non-libxul builds.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 504525 [details] [diff] [review]
Patch (v1)

r=me

Comment 5

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/0133f1361d2b